Re: [PHP-DEV] Naming issues, solutions

2014-08-25 Thread Pierre Joye
On Aug 25, 2014 1:14 PM, "Dmitry Stogov" wrote: > > > > > On Mon, Aug 25, 2014 at 2:59 PM, Pierre Joye wrote: >> >> >> On Aug 25, 2014 12:56 PM, "Dmitry Stogov" wrote: >> > >> > >> > >> > >> > On Mon, Aug 25, 2014 at 2:45 PM, Pierre Joye wrote: >> >> >> >> >> >> On Aug 25, 2014 9:22 AM, "Dmitry

Re: [PHP-DEV] Naming issues, solutions

2014-08-25 Thread Dmitry Stogov
On Mon, Aug 25, 2014 at 2:59 PM, Pierre Joye wrote: > > On Aug 25, 2014 12:56 PM, "Dmitry Stogov" wrote: > > > > > > > > > > On Mon, Aug 25, 2014 at 2:45 PM, Pierre Joye > wrote: > >> > >> > >> On Aug 25, 2014 9:22 AM, "Dmitry Stogov" wrote: > >> > > >> > Hi Pierre, > >> > > >> > I'm glad, you

Re: [PHP-DEV] Naming issues, solutions

2014-08-25 Thread Pierre Joye
On Aug 25, 2014 12:56 PM, "Dmitry Stogov" wrote: > > > > > On Mon, Aug 25, 2014 at 2:45 PM, Pierre Joye wrote: >> >> >> On Aug 25, 2014 9:22 AM, "Dmitry Stogov" wrote: >> > >> > Hi Pierre, >> > >> > I'm glad, you agree to rename IS_INT back to IS_LONG. >> > >> > zend_long and size_t usage looks

Re: [PHP-DEV] Naming issues, solutions

2014-08-25 Thread Dmitry Stogov
On Mon, Aug 25, 2014 at 2:45 PM, Pierre Joye wrote: > > On Aug 25, 2014 9:22 AM, "Dmitry Stogov" wrote: > > > > Hi Pierre, > > > > I'm glad, you agree to rename IS_INT back to IS_LONG. > > > > zend_long and size_t usage looks fine. > > > > I see no problems changing zend_string related API and r

Re: [PHP-DEV] Naming issues, solutions

2014-08-25 Thread Pierre Joye
On Aug 25, 2014 9:22 AM, "Dmitry Stogov" wrote: > > Hi Pierre, > > I'm glad, you agree to rename IS_INT back to IS_LONG. > > zend_long and size_t usage looks fine. > > I see no problems changing zend_string related API and related macros introduced in NG. They are new for everyone. > I hope, the c

Re: [PHP-DEV] Naming issues, solutions

2014-08-25 Thread Dmitry Stogov
Hi Pierre, I'm glad, you agree to rename IS_INT back to IS_LONG. zend_long and size_t usage looks fine. I see no problems changing zend_string related API and related macros introduced in NG. They are new for everyone. I hope, the changes won't make API less clear or useful (so it would be great

Re: [PHP-DEV] Naming issues, solutions

2014-08-24 Thread Pierre Joye
On Sun, Aug 24, 2014 at 3:20 PM, Rouven Weßling wrote: > > >> Am 24.08.2014 um 14:30 schrieb Pierre Joye : >> >> zend_uint > int32_t > > Is that a typo? If it's not, why are you changing it to signed? typo. It should be: zend_uint > uint32_t Thanks :) > Best regards > Rouven -- Pierre

Re: [PHP-DEV] Naming issues, solutions

2014-08-24 Thread Rouven Weßling
> Am 24.08.2014 um 14:30 schrieb Pierre Joye : > > zend_uint > int32_t Is that a typo? If it's not, why are you changing it to signed? Best regards Rouven -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-DEV] Naming issues, solutions

2014-08-24 Thread Laruence
Hey: On Sun, Aug 24, 2014 at 8:30 PM, Pierre Joye wrote: > Hi, > > Nikita, Xinchen and I have sit down together this morning to solve a > couple of naming issues, those having > caused some flames, trolls and FUDs in the last couple of days. The > good news is we have found a consensus > that sol

[PHP-DEV] Naming issues, solutions

2014-08-24 Thread Pierre Joye
Hi, Nikita, Xinchen and I have sit down together this morning to solve a couple of naming issues, those having caused some flames, trolls and FUDs in the last couple of days. The good news is we have found a consensus that solves our concerns, consistency and reduce the amount of changes in existi