Re: [PHP-DEV] Microseconds to error log

2023-01-06 Thread Mikhail Galanin via internals
Hi Derick, Jakub and the team, Thank you so much for your input. Sorry for being so slow with this -- I haven't forgotten, it's just unfortunately, I'm not capable to handle all the things going around but I keep trying :) I did some research about why we keep using plain log files and our folks

Re: [PHP-DEV] Microseconds to error log

2022-11-29 Thread Jakub Zelenka
On Mon, Nov 28, 2022 at 4:13 PM Derick Rethans wrote: > On Fri, 21 Oct 2022, Mikhail Galanin via internals wrote: > > Looking into the future, probably we would like to have this format > > configurable, if so it looks easy to do but still I can't see an easy > > way to handle the microseconds is

Re: [PHP-DEV] Microseconds to error log

2022-11-28 Thread Derick Rethans
On Fri, 21 Oct 2022, Mikhail Galanin via internals wrote: > (4) Derrek Rethans suggested introducing a new function (e.g. > php_format_date_ex) that > takes care of usecs (see the thread on Github) It's 'Derick' :-) > Looking into the future, probably we would like to have this format > co

Re: [PHP-DEV] Microseconds to error log

2022-11-26 Thread Craig Francis
On Fri, 25 Nov 2022 at 14:01, Mikhail Galanin < mikhail.gala...@team.bumble.com> wrote: > 2. The INI-thing. When initially I mentioned being configurable, I > realised that it could've been perceived in many different ways: > > - we can enable/disable the microseconds > - we can choose from a pre-

Re: [PHP-DEV] Microseconds to error log

2022-11-25 Thread Mikhail Galanin via internals
Hello good people, (really hope I'm writing into the right thread this time). I updated the patch considering the thoughts from this thread. Thank you all for being so much responsive and helpful! Meanwhile, there are two changes: * Added function `php_format_timestamp' that takes microseconds

Re: [PHP-DEV] Microseconds to error log

2022-11-01 Thread Craig Francis
On Mon, 31 Oct 2022 at 18:23, Rowan Tommins wrote: > I guess we could have the setting be "use new date format", and control > both the precision and whether the format is ISO 8601 compliant, but I'm > not convinced of the value > Thanks, and that's fair to avoid complicating the error handling

Re: [PHP-DEV] Microseconds to error log

2022-10-31 Thread Rowan Tommins
On 31/10/2022 10:16, Craig Francis wrote: On Sun, 30 Oct 2022 at 17:42, Rowan Tommins wrote: In case of any confusion, I think this should be configurable as "include microseconds: on / off", not configurable as "enter date format". Any reason it can't be configured to use ISO 8

Re: [PHP-DEV] Microseconds to error log

2022-10-31 Thread Craig Francis
On Sun, 30 Oct 2022 at 17:42, Rowan Tommins wrote: > In case of any confusion, I think this should be configurable as > "include microseconds: on / off", not configurable as "enter date format". > Any reason it can't be configured to use ISO 8601? Apache 2.4 allows you to use `LogFormat "... [

Re: [PHP-DEV] Microseconds to error log

2022-10-30 Thread Rowan Tommins
On 30/10/2022 11:38, Jakub Zelenka wrote: I think the consensus is more that it needs to be configurable and I'm in favour of configurable option as well as we should not break the current format. In case of any confusion, I think this should be configurable as "include microseconds: on /

Re: [PHP-DEV] Microseconds to error log

2022-10-30 Thread Jakub Zelenka
Hi, Please try to not top post. On Fri, Oct 28, 2022 at 10:29 AM Mikhail Galanin via internals < internals@lists.php.net> wrote: > Hello everyone, > > I tried following Derrek's approach (to introduce a new function). > > A couple of considerations: > > We used to have some pain when this format

Re: [PHP-DEV] Microseconds to error log

2022-10-28 Thread tyson andre
Hi Mikhail, > >Basically, we have quite a high-loaded environment and we really want > >to see timestamps containing milli-/microseconds in our logs. > > I'm not knowledgeable enough to comment on the implementation details, but > from a user point of view I agree the feature would be useful. It

Re: [PHP-DEV] Microseconds to error log

2022-10-28 Thread Mikhail Galanin via internals
Hello everyone, I tried following Derrek's approach (to introduce a new function). A couple of considerations: We used to have some pain when this format changed last time (I can't remember details, unfortunately) but I don't feel like making an option to provide backward compatibility is a good

Re: [PHP-DEV] Microseconds to error log

2022-10-21 Thread Rowan Tommins
On 21 October 2022 08:47:30 BST, Mikhail Galanin via internals wrote: >Basically, we have quite a high-loaded environment and we really want >to see timestamps containing milli-/microseconds in our logs. I'm not knowledgeable enough to comment on the implementation details, but from a user poi

[PHP-DEV] Microseconds to error log

2022-10-21 Thread Mikhail Galanin via internals
Description Hi there, I started this thread on GitHub but Christoph (cmb69) suggested this is the better place to discuss such a thing. (initial post: https://github.com/php/php-src/issues/9745) Basically, we have quite a high-loaded environment and we really want to see timestamps containing