Re: [PHP-DEV] Magic quotes removal previous patch

2011-07-22 Thread Richard Quadling
On 22 July 2011 12:30, Pierre Joye wrote: > patch applied to trunk and 5.4, had to resist not to apply it to 5.3 :D As the great collective once said, Resistance is futile. Surrender to your inner-borg. -- Richard Quadling Twitter : EE : Zend : PHPDoc @RQuadling : e-e.com/M_248814.html : bit.l

Re: [PHP-DEV] Magic quotes removal previous patch

2011-07-22 Thread Pierre Joye
patch applied to trunk and 5.4, had to resist not to apply it to 5.3 :D On Thu, Jul 21, 2011 at 6:54 PM, Adam Harvey wrote: > On 21 July 2011 02:19, Pierre Joye wrote: >> Now the only question remaining is which level warning we should use >> for the setter. I'm happy with E_CORE. Objections? >

Re: [PHP-DEV] Magic quotes removal previous patch

2011-07-21 Thread Adam Harvey
On 21 July 2011 02:19, Pierre Joye wrote: > Now the only question remaining is which level warning we should use > for the setter. I'm happy with E_CORE. Objections? None here. +1 for E_CORE_ERROR — it's exactly what it's for. Adam -- PHP Internals - PHP Runtime Development Mailing List To unsu

Re: [PHP-DEV] Magic quotes removal previous patch

2011-07-21 Thread Keloran
+1 E_CORE On Thu, Jul 21, 2011 at 11:46 AM, Paul Dragoonis wrote: > On Thu, Jul 21, 2011 at 11:31 AM, Gwynne Raskind > wrote: > > +1 to E_CORE. > > No objections against it, so +1 E_CORE > > > > > -- Gwynne > > > > > > > > On Thu, Jul 21, 2011 at 06:28, Pierrick Charron > wrote: > >> I'm also o

Re: [PHP-DEV] Magic quotes removal previous patch

2011-07-21 Thread Paul Dragoonis
On Thu, Jul 21, 2011 at 11:31 AM, Gwynne Raskind wrote: > +1 to E_CORE. No objections against it, so +1 E_CORE > > -- Gwynne > > > > On Thu, Jul 21, 2011 at 06:28, Pierrick Charron wrote: >> I'm also ok with E_CORE. >> >> Pierrick >> >> On 21 July 2011 05:19, Pierre Joye wrote: >>> hi Pierrick

Re: [PHP-DEV] Magic quotes removal previous patch

2011-07-21 Thread Gwynne Raskind
+1 to E_CORE. -- Gwynne On Thu, Jul 21, 2011 at 06:28, Pierrick Charron wrote: > I'm also ok with E_CORE. > > Pierrick > > On 21 July 2011 05:19, Pierre Joye wrote: >> hi Pierrick! >> >> Thanks for the updated patch :) >> >> Now the only question remaining is which level warning we should use

Re: [PHP-DEV] Magic quotes removal previous patch

2011-07-21 Thread Pierrick Charron
I'm also ok with E_CORE. Pierrick On 21 July 2011 05:19, Pierre Joye wrote: > hi Pierrick! > > Thanks for the updated patch :) > > Now the only question remaining is which level warning we should use > for the setter. I'm happy with E_CORE. Objections? > > On Thu, Jul 21, 2011 at 2:18 AM, Pierri

Re: [PHP-DEV] Magic quotes removal previous patch

2011-07-21 Thread Richard Quadling
On 21 July 2011 10:19, Pierre Joye wrote: > hi Pierrick! > > Thanks for the updated patch :) > > Now the only question remaining is which level warning we should use > for the setter. I'm happy with E_CORE. Objections? > Baited breath I've got the champagne on ice ... so long mq! -- Richa

Re: [PHP-DEV] Magic quotes removal previous patch

2011-07-21 Thread Pierre Joye
hi Pierrick! Thanks for the updated patch :) Now the only question remaining is which level warning we should use for the setter. I'm happy with E_CORE. Objections? On Thu, Jul 21, 2011 at 2:18 AM, Pierrick Charron wrote: > I tried to send the patch as a .txt file but it seems my mail was not >

Re: [PHP-DEV] Magic quotes removal previous patch

2011-07-20 Thread Pierrick Charron
I tried to send the patch as a .txt file but it seems my mail was not send to internals since i don't see it on news.php.net. Anyway you'll find patch (code + tests) here : - http://www.adoy.net/php/remove-magic-quotes.txt - http://www.adoy.net/php/remove-magic-quotes-tests.txt Pierrick On 20 Ju

Re: [PHP-DEV] Magic quotes removal previous patch

2011-07-20 Thread Pierrick Charron
Hi, I have a more recent one on my laptop. I'll update it tonight or tomorrow to make sure it work on 5.4 and send it in this thread. Pierrick On 20 July 2011 15:44, Pierre Joye wrote: > hi, > > Please find as attachment the previous patch to remove the magic quotes. > > The log I was using ba