Re: [PHP-DEV] Lazy writing in the session, session-lock-ini, and bug #68331

2014-11-06 Thread Yasuo Ohgaki
Hi Andrey, The problem was "there was partial patch, while patch that overwrite it was not merged". I was confused. Offensive patch is removed for now already and this issue is closed. Regards, -- Yasuo Ohgaki yohg...@ohgaki.net On Thu, Nov 6, 2014 at 5:42 PM, Andrey Andreev wrote: > Hi, > >

Re: [PHP-DEV] Lazy writing in the session, session-lock-ini, and bug #68331

2014-11-06 Thread Andrey Andreev
Hi, On Thu, Nov 6, 2014 at 4:02 AM, Yasuo Ohgaki wrote: > HI all, > > On Thu, Nov 6, 2014 at 6:30 AM, Yasuo Ohgaki wrote: > >> On Wed, Nov 5, 2014 at 10:54 AM, Damian Wadley wrote: >> >>> Apparently this caused >>> problems for some people as they made 68331 a few days ago. >>> >> >> Just a qui

Re: [PHP-DEV] Lazy writing in the session, session-lock-ini, and bug #68331

2014-11-06 Thread Andrey Andreev
Hi Yasuo, On Thu, Nov 6, 2014 at 3:42 AM, Yasuo Ohgaki wrote: > Hi Andrey, > > On Thu, Nov 6, 2014 at 8:23 AM, Andrey Andreev wrote: >> >> Short-term fix for 5.6 is obviously to revert the commit. I was vocal >> mostly because of principle at the time, but this issue is an example >> why. > > >

Re: [PHP-DEV] Lazy writing in the session, session-lock-ini, and bug #68331

2014-11-05 Thread Ferenc Kovacs
2014.11.06. 6:02 ezt írta ("Yasuo Ohgaki" ): > > Hi Damian, > > On Wed, Nov 5, 2014 at 10:54 AM, Damian Wadley wrote: > > > https://bugs.php.net/bug.php?id=68331 > > > > I've reverted incomplete patch for the RFC. Thanks! > > Since the RFC patch > https://github.com/yohgaki/php-src/compare/PHP-5

Re: [PHP-DEV] Lazy writing in the session, session-lock-ini, and bug #68331

2014-11-05 Thread Yasuo Ohgaki
Hi Damian, On Wed, Nov 5, 2014 at 10:54 AM, Damian Wadley wrote: > https://bugs.php.net/bug.php?id=68331 > I've reverted incomplete patch for the RFC. Since the RFC patch https://github.com/yohgaki/php-src/compare/PHP-5.6-rfc-session-lock was not merged yet, it has to be removed for now. We h

Re: [PHP-DEV] Lazy writing in the session, session-lock-ini, and bug #68331

2014-11-05 Thread Yasuo Ohgaki
HI all, On Thu, Nov 6, 2014 at 6:30 AM, Yasuo Ohgaki wrote: > On Wed, Nov 5, 2014 at 10:54 AM, Damian Wadley wrote: > >> Apparently this caused >> problems for some people as they made 68331 a few days ago. >> > > Just a quick note for this. The user would like to access session > data(session

Re: [PHP-DEV] Lazy writing in the session, session-lock-ini, and bug #68331

2014-11-05 Thread Yasuo Ohgaki
Hi Andrey, On Thu, Nov 6, 2014 at 8:23 AM, Andrey Andreev wrote: > Short-term fix for 5.6 is obviously to revert the commit. I was vocal > mostly because of principle at the time, but this issue is an example > why. > Did you? I don't think so. The reason that I didn't provide that user land "

Re: [PHP-DEV] Lazy writing in the session, session-lock-ini, and bug #68331

2014-11-05 Thread Andrey Andreev
Hi, On Wed, Nov 5, 2014 at 11:30 PM, Yasuo Ohgaki wrote: > > BTW, anyone know the reason why the user need to call > session_write_close()/session_commit() > unconditionally? Accounting, perhaps? Releasing locks is one example. In userland implementations though, it could be all kinds of applica

Re: [PHP-DEV] Lazy writing in the session, session-lock-ini, and bug #68331

2014-11-05 Thread Andrey Andreev
Hi all, On Wed, Nov 5, 2014 at 9:52 PM, Ferenc Kovacs wrote: > > Hi, > > thanks for the report. > first let me clarify a couple of things: > > 1, neither of https://wiki.php.net/rfc/session-lock-ini or > https://wiki.php.net/rfc/session-read_only-lazy_write made into 5.6 in their > proposed forms

Re: [PHP-DEV] Lazy writing in the session, session-lock-ini, and bug #68331

2014-11-05 Thread Yasuo Ohgaki
Hi all, On Wed, Nov 5, 2014 at 10:54 AM, Damian Wadley wrote: > Apparently this caused > problems for some people as they made 68331 a few days ago. > Just a quick note for this. The user would like to access session data(session handler) regardless of data modification. I suppose it could be s

Re: [PHP-DEV] Lazy writing in the session, session-lock-ini, and bug #68331

2014-11-05 Thread Ferenc Kovacs
On Wed, Nov 5, 2014 at 6:49 PM, Mark Caudill wrote: > > https://bugs.php.net/bug.php?id=68331 > > > > I was hoping the submitter (or one of their coworkers who commented on > > it) would reach out to the list themselves to get more information > > since I don't know the whole situation. I did ask

Re: [PHP-DEV] Lazy writing in the session, session-lock-ini, and bug #68331

2014-11-05 Thread Mark Caudill
> https://bugs.php.net/bug.php?id=68331 > > I was hoping the submitter (or one of their coworkers who commented on > it) would reach out to the list themselves to get more information > since I don't know the whole situation. I did ask them to... Sorry, I had an email written up to send out to the

[PHP-DEV] Lazy writing in the session, session-lock-ini, and bug #68331

2014-11-04 Thread Damian Wadley
https://bugs.php.net/bug.php?id=68331 I was hoping the submitter (or one of their coworkers who commented on it) would reach out to the list themselves to get more information since I don't know the whole situation. I did ask them to... Story thus far: Yasuo's session-lock-ini RFC [1] in February