Re: [PHP-DEV] LDAP controls support API [Question for the RM at the end]

2017-07-27 Thread Côme Chilliet
Hello, The problem with your changes seems to be that when using "z/!" for retdata, if I call the method with a unset var, which will be the most common case as it’s an out parameter, the test if (retdata) will fail and the method will behave as if I passed NULL. Côme -- PHP Internals - PHP R

Re: [PHP-DEV] LDAP controls support API [Question for the RM at the end]

2017-07-27 Thread Côme Chilliet
Le mercredi 26 juillet 2017, 12:48:04 CEST Sara Golemon a écrit : > The current return value for 4 or more args is simply `true`, so the > BC break would be trivial to make that a resource (which evaluates as > true), but I think we can make that even simpler. Just fix it before > beta3 (or beta2

Re: [PHP-DEV] LDAP controls support API [Question for the RM at the end]

2017-07-26 Thread Sara Golemon
On Wed, Jul 26, 2017 at 12:48 PM, Sara Golemon wrote: > On Wed, Jul 26, 2017 at 12:11 PM, Côme Chilliet wrote: >> As ldap_exop was merged in 7.2, is it possible to have a BC on it for 7.3 or >> not? >> It would be by adding options in the middle: >> resource ldap_exop(resource link, string reqoi

Re: [PHP-DEV] LDAP controls support API [Question for the RM at the end]

2017-07-26 Thread Sara Golemon
On Wed, Jul 26, 2017 at 12:11 PM, Côme Chilliet wrote: > As ldap_exop was merged in 7.2, is it possible to have a BC on it for 7.3 or > not? > It would be by adding options in the middle: > resource ldap_exop(resource link, string reqoid [, > string reqdata [, array servercontrols [, array client

Re: [PHP-DEV] LDAP controls support API [Question for the RM at the end]

2017-07-26 Thread Côme Chilliet
Hello again, I was able to easily add controls support to search operations since they already return the result object. (my previous message concerns modification operations) But I’m a bit stuck for EXOPs. Since ldap_exop generic method can return the result object I thought it would be easy