Re: [PHP-DEV] Iterators and new destructors

2004-02-08 Thread Marcus Boerger
Hello Andi, without looking at the code i guessed iterators needed both, destruction and cleaning. But unfortunatley i fear i cannot look into it until wednesday. So i took a few mins right now and i'd say you should commit Rob's patch which seems correct. regards marcus Sunday, February 8, 2004

Re: [PHP-DEV] Iterators and new destructors

2004-02-08 Thread Andi Gutmans
I submitted the patch for checking free_storage != NULL. Marcus, will have to look into SPL and see if dtor is more suitable than free_storage. Andi At 11:39 AM 2/8/2004 -0500, Rob Richards wrote: It appears that the zend iterators need to go back to using the dtor callback rather than free stor

[PHP-DEV] Iterators and new destructors

2004-02-08 Thread Rob Richards
It appears that the zend iterators need to go back to using the dtor callback rather than free storage. throwing an unhandled exception in any of the iterator foreach loops in SPL, SXE and DOM results in a segfault due to improper cleanup. To reproduce, put a throw new exception within one of the