On Sun, Apr 14, 2024, at 11:49 AM, Tim Düsterhus wrote:
> Hi
>
> On 4/14/24 16:33, Gina P. Banyard wrote:
>> Considering that PHP 8.4 is also adding new rounding modes via the "Add 4
>> new rounding modes to round() function" RFC [4] attempting to solve this
>> issue in this next version of PHP s
On Sun, Apr 14, 2024 at 9:50 AM Tim Düsterhus wrote:
>
> I don't think it should be in a namespace. The name is sufficiently
> unique and clear. Without a broader concept for the namespace, we
> probably should not introduce one.
>
>
+1
For this, I don't think a namespace is necessary. Though I
Hi
On 4/14/24 16:33, Gina P. Banyard wrote:
Considering that PHP 8.4 is also adding new rounding modes via the "Add 4 new
rounding modes to round() function" RFC [4] attempting to solve this issue in this
next version of PHP seems like a good idea.
In my discussions with Saki about this issue,
On 14 April 2024 16:55:43 BST, Saki Takamachi wrote:
>Hi Gina,
>
>> Hello internals,
>>
>> While reviewing the PR for the "Adding bcround, bcfloor and bcceil to
>> BCMath" RFC [1] with the different rounding modes,
>> I was made aware of the unfortunate wrong terminology usage of
>> PHP_ROUND_H
Hi Gina,
> Hello internals,
>
> While reviewing the PR for the "Adding bcround, bcfloor and bcceil to BCMath"
> RFC [1] with the different rounding modes,
> I was made aware of the unfortunate wrong terminology usage of
> PHP_ROUND_HALF_UP and PHP_ROUND_HALF_DOWN.
>
> Indeed, PHP_ROUND_HALF_UP
Hello internals,
While reviewing the PR for the "Adding bcround, bcfloor and bcceil to BCMath"
RFC [1] with the different rounding modes,
I was made aware of the unfortunate wrong terminology usage of
PHP_ROUND_HALF_UP and PHP_ROUND_HALF_DOWN.
Indeed, PHP_ROUND_HALF_UP is implemented as "roundi
