Re: [PHP-DEV] Incorrect Argument Count Error

2016-08-22 Thread Davey Shafik
On Mon, Aug 22, 2016 at 5:59 PM, Derick Rethans wrote: > On Fri, 19 Aug 2016, Davey Shafik wrote: > > > b) a huge BC break (stuff that currently throws a warning in > > strict_types mode will now throw an exception, similar BC break as > > we're implementing for userland functions regardless of s

Re: [PHP-DEV] Incorrect Argument Count Error

2016-08-22 Thread Derick Rethans
On Fri, 19 Aug 2016, Davey Shafik wrote: > b) a huge BC break (stuff that currently throws a warning in > strict_types mode will now throw an exception, similar BC break as > we're implementing for userland functions regardless of strict_types) IMO, that's not acceptable at all between 7.0 and

Re: [PHP-DEV] Incorrect Argument Count Error

2016-08-22 Thread Davey Shafik
On Fri, Aug 19, 2016 at 10:27 PM, Kalle Sommer Nielsen wrote: > 2016-08-19 15:05 GMT+02:00 Davey Shafik : > > Hey Internals, > > > > I'm working on the patch to change the error exception to > > \ArgumentCountError instead of \Error when too few, or too many arguments > > are passed in as discuss

Re: [PHP-DEV] Incorrect Argument Count Error

2016-08-19 Thread Kalle Sommer Nielsen
2016-08-19 15:05 GMT+02:00 Davey Shafik : > Hey Internals, > > I'm working on the patch to change the error exception to > \ArgumentCountError instead of \Error when too few, or too many arguments > are passed in as discussed a couple of weeks ago. > > To be BC with 7.0, this extends \TypeError, wh

[PHP-DEV] Incorrect Argument Count Error

2016-08-19 Thread Davey Shafik
Hey Internals, I'm working on the patch to change the error exception to \ArgumentCountError instead of \Error when too few, or too many arguments are passed in as discussed a couple of weeks ago. To be BC with 7.0, this extends \TypeError, which is the exception currently thrown when strict_type