Re: [PHP-DEV] ICU and the INTL_IDNA_VARIANT_2003 deprecation

2018-01-19 Thread Andrey Andreev
Hi again, On Fri, Jan 19, 2018 at 9:30 PM, Niklas Keller wrote: > > I think we only have to bump the minimum version once 7.4 is out, because > only 7.4 will change the default. You only get a deprecation notice now, > which is totally fine. > I disagree that it's totally fine. I mean, it's tech

Re: [PHP-DEV] ICU and the INTL_IDNA_VARIANT_2003 deprecation

2018-01-19 Thread Niklas Keller
2018-01-19 20:09 GMT+01:00 Andrey Andreev : > On Fri, Jan 19, 2018 at 8:55 PM, Sara Golemon wrote: > > (Seriously though, who's on php 7.2, but hasn't updated ICU for that > > long?) > > Probably nobody yet. The issue was uncovered in code that assumed the > constant was available on 5.4+, as not

Re: [PHP-DEV] ICU and the INTL_IDNA_VARIANT_2003 deprecation

2018-01-19 Thread Andrey Andreev
On Fri, Jan 19, 2018 at 8:55 PM, Sara Golemon wrote: > (Seriously though, who's on php 7.2, but hasn't updated ICU for that > long?) Probably nobody yet. The issue was uncovered in code that assumed the constant was available on 5.4+, as noted in the manual, but it turned out there's people on 5.

Re: [PHP-DEV] ICU and the INTL_IDNA_VARIANT_2003 deprecation

2018-01-19 Thread Sara Golemon
On Fri, Jan 19, 2018 at 1:11 PM, Andrey Andreev wrote: > My immediate thought is to simply bump the ICU version requirement, > but I have no idea what kind of an impact that would have. > According to that page, 46 is seven years old. I for one am 100% okay with making that the minimum, though no

[PHP-DEV] ICU and the INTL_IDNA_VARIANT_2003 deprecation

2018-01-19 Thread Andrey Andreev
Hello, It seems that an important detail was missed in the RFC to deprecate INTL_IDNA_VARIANT_2003 in PHP 7.2.0 (and later remove it). The only other option available - INTL_IDNA_VARIANT_UTS46 - may not be available at all, as PHP has ICU 4.0 as its minimum requirement, but support for UTS#46 was