Re: [PHP-DEV] Git workflow, PRs and php-cvs ML

2020-09-18 Thread Matteo Beccati
Hi Nikita, On 17/09/2020 20:12, Nikita Popov wrote: > Oh sorry, completely misunderstood what you were referring to. I believe > this is related to the size of the diff. Large diffs probably run into > some size limit and don't reach the php-cvs list. I don't know to be honest. From a quick look

Re: [PHP-DEV] Git workflow, PRs and php-cvs ML

2020-09-18 Thread Remi Collet
Le 17/09/2020 à 20:12, Nikita Popov a écrit : > On Wed, Sep 16, 2020 at 1:20 PM Matteo Beccati wrote: > >> Hi Nikita, >> >> On 16/09/2020 12:46, Nikita Popov wrote: >>> No, this just means that your CI is running tests that our CI doesn't. >>> In this case, you are probably using a different MySQ

Re: [PHP-DEV] Git workflow, PRs and php-cvs ML

2020-09-17 Thread Nikita Popov
On Wed, Sep 16, 2020 at 1:20 PM Matteo Beccati wrote: > Hi Nikita, > > On 16/09/2020 12:46, Nikita Popov wrote: > > No, this just means that your CI is running tests that our CI doesn't. > > In this case, you are probably using a different MySQL version and thus > > run a different subset of test

Re: [PHP-DEV] Git workflow, PRs and php-cvs ML

2020-09-16 Thread Matteo Beccati
Hi Nikita, On 16/09/2020 12:46, Nikita Popov wrote: > No, this just means that your CI is running tests that our CI doesn't. > In this case, you are probably using a different MySQL version and thus > run a different subset of tests. I know that, and that's why I keep it running it ;-) I was jus

[PHP-DEV] Git workflow, PRs and php-cvs ML

2020-09-16 Thread Matteo Beccati
Hey everybody, I've noticed a test failing today on my CI and went through my local php-cvs ML archive to see what could have caused it, without finding a match. That has happened a few times already and I believe it was always with some "Closes GH-XXX" commits. I'm just guessing here, but maybe

Re: [PHP-DEV] Git workflow, PRs and php-cvs ML

2020-09-16 Thread Nikita Popov
On Wed, Sep 16, 2020 at 12:44 PM Matteo Beccati wrote: > Hey everybody, > > I've noticed a test failing today on my CI and went through my local > php-cvs ML archive to see what could have caused it, without finding a > match. That has happened a few times already and I believe it was always > wi