Thanks for the feedback Gustavo.
New patch is here: https://gist.github.com/1582997
Test case: https://gist.github.com/1583022
Comments are inline.
On Mon, Jan 9, 2012 at 8:17 AM, Gustavo Lopes wrote:
> On Mon, 09 Jan 2012 04:59:09 +0100, Paul Dragoonis
> wrote:
>
>> Hey Internals,
>>
>> I've
On Mon, Jan 9, 2012 at 9:17 AM, Gustavo Lopes wrote:
> On Mon, 09 Jan 2012 04:59:09 +0100, Paul Dragoonis
> wrote:
>
> Hey Internals,
>>
>> I've finished the patch, and with approval i'd like to push to trunk,
>> even though i'm aware we have a 5_4 branch code freeze.
>>
>> Can someone review my
On Mon, 09 Jan 2012 04:59:09 +0100, Paul Dragoonis
wrote:
Hey Internals,
I've finished the patch, and with approval i'd like to push to trunk,
even though i'm aware we have a 5_4 branch code freeze.
Can someone review my work and provide feedback/approval?
[1] https://gist.github.com/15809
Hey Internals,
I've finished the patch, and with approval i'd like to push to trunk,
even though i'm aware we have a 5_4 branch code freeze.
Can someone review my work and provide feedback/approval?
[1] https://gist.github.com/1580974
Thanks,
Paul Dragoonis.
On Sun, Jan 8, 2012 at 6:18 PM, Pau
PHP 5_4 branch.
Here's the diff as a gist: https://gist.github.com/e3e1da28123017ba568d
On Sun, Jan 8, 2012 at 5:43 PM, Etienne Kneuss wrote:
> It works fine here on trunk, what code-base are you targetting?
>
> Best,
>
> On Sun, Jan 8, 2012 at 18:31, Paul Dragoonis wrote:
>> Here's the patch.
It works fine here on trunk, what code-base are you targetting?
Best,
On Sun, Jan 8, 2012 at 18:31, Paul Dragoonis wrote:
> Here's the patch. At the moment my clear() method clones the
> functionality of count() just as a prototype to get things working
> before i make it do the actual clear fun
Here's the patch. At the moment my clear() method clones the
functionality of count() just as a prototype to get things working
before i make it do the actual clear functionality.
Patch attached to this email, made using 'svn diff'
- Paul Dragoonis.
On Sun, Jan 8, 2012 at 4:38 PM, Etienne Kneuss
Hi Paul,
On Sun, Jan 8, 2012 at 16:32, Paul Dragoonis wrote:
> Hey Internals,
>
> I'm trying to add a new method to SplDoublyLinkedList named "clear"
>
> I've successfully compiled please see the output:
>
> $dll = new \SplDoublyLinkedList();
> var_dump(get_class_methods($dll));
> array(23) {
>
Hey Internals,
I'm trying to add a new method to SplDoublyLinkedList named "clear"
I've successfully compiled please see the output:
$dll = new \SplDoublyLinkedList();
var_dump(get_class_methods($dll));
array(23) {
[0]=>
string(5) "clear"
So my clear method is there, but as soon as i try to
