Re: [PHP-DEV] Fix for #68021

2014-09-17 Thread Johannes Schlüter
On Wed, 2014-09-17 at 16:03 +0200, Johannes Schlüter wrote: > > If this is changed is done I'd suggest escaping the regexp accordingly > to be on the safe side. ah, I see this is already done. Still see no big need to limit this to ASCII (yes, I read the user's report) johannes -- PHP Intern

Re: [PHP-DEV] Fix for #68021

2014-09-17 Thread Johannes Schlüter
On Wed, 2014-09-17 at 21:51 +0800, Tjerk Meesters wrote: > Hi, > > I’ve authored a fix for browscap: > https://github.com/php/php-src/pull/827 > > Bug report: https://bugs.php.net/bug.php?id=68021 > > It replaces the current expression delimiters of \xA7 with a tilde (~) > that’s ASCII compatibl

[PHP-DEV] Fix for #68021

2014-09-17 Thread Tjerk Meesters
Hi, I’ve authored a fix for browscap: https://github.com/php/php-src/pull/827 Bug report: https://bugs.php.net/bug.php?id=68021 It replaces the current expression delimiters of \xA7 with a tilde (~) that’s ASCII compatible and therefore plays nice with UTF-8. Seems like a no-brainer to apply t