Re: [PHP-DEV] Fileinfo fixes for windows

2012-04-10 Thread Pierre Joye
Hi! On Wed, Apr 11, 2012 at 7:35 AM, Stas Malyshev wrote: > Hi! > >> btw, It is not a realy issue as we won't use 5.4.1 tests to test the >> release but 5.4's branch ones. Too many false positive. > > Who are we? My team and I, as always when we refer to that. > I'll definitely be using 5.4.1,

Re: [PHP-DEV] Fileinfo fixes for windows

2012-04-10 Thread Stas Malyshev
Hi! > btw, It is not a realy issue as we won't use 5.4.1 tests to test the > release but 5.4's branch ones. Too many false positive. Who are we? I'll definitely be using 5.4.1, since that's what I will be releasing. There's no point in testing code different from one you're releasing. Do you mean

Re: [PHP-DEV] Fileinfo fixes for windows

2012-04-10 Thread Pierre Joye
hi Stas, On Wed, Apr 11, 2012 at 12:24 AM, Stas Malyshev wrote: > Hi! > >> However, as you won't merge the tests fixes either, we won't 5.4.1's >> tests at all to valid the build (way too many false positive), it does >> not really matter anymore. > > Wait, are we talking about new test fixes or

Re: [PHP-DEV] Fileinfo fixes for windows

2012-04-10 Thread Stas Malyshev
Hi! > However, as you won't merge the tests fixes either, we won't 5.4.1's > tests at all to valid the build (way too many false positive), it does > not really matter anymore. Wait, are we talking about new test fixes or about tests that are broken in RC1 and need fixing? I was assuming it's the

Re: [PHP-DEV] Fileinfo fixes for windows

2012-04-10 Thread Pierre Joye
hi Stas, This is zero code or tests change. This is pure restoring what we are supposed to have, like it was in svn. However, as you won't merge the tests fixes either, we won't 5.4.1's tests at all to valid the build (way too many false positive), it does not really matter anymore. Cheers, On

Re: [PHP-DEV] Fileinfo fixes for windows

2012-04-10 Thread Stas Malyshev
Hi! > Another important thing i didn't mention - there is a lot of test fixes > going to be commited, they should be merged into release branches too. Test fixes are definitely not critical bugs. So I would prefer handling them as usual fixes. -- Stanislav Malyshev, Software Architect SugarCRM:

Re: [PHP-DEV] Fileinfo fixes for windows

2012-04-10 Thread Anatoliy Belsky
Another important thing i didn't mention - there is a lot of test fixes going to be commited, they should be merged into release branches too. thanks ) On Tue, April 10, 2012 13:23, Anatoliy Belsky wrote: > Hi guys, > > I wanted just ask about the latest fileinfo fixes as I see so far nothing > w

[PHP-DEV] Fileinfo fixes for windows

2012-04-10 Thread Anatoliy Belsky
Hi guys, I wanted just ask about the latest fileinfo fixes as I see so far nothing was merged. This fixes should be merged into the current 5.3.11 and 5.4.1 branches. The info about the changes is in the following tickets: https://bugs.php.net/bug.php?id=61565 https://bugs.php.net/bug.php?id=615