Re: [PHP-DEV] Feature: use Posix ACL for FPM socket

2014-12-01 Thread Julien Pauli
On Sun, Nov 30, 2014 at 8:33 PM, Ferenc Kovacs wrote: > On Sun, Nov 30, 2014 at 8:09 PM, Rowan Collins > wrote: > >> On 30/11/2014 18:06, Remi Collet wrote: >> >>> >However, I think we should stop including features in our patch >releases. I've heard a few others express similar sentiment, b

Re: [PHP-DEV] Feature: use Posix ACL for FPM socket

2014-11-30 Thread Ferenc Kovacs
On Sun, Nov 30, 2014 at 8:09 PM, Rowan Collins wrote: > On 30/11/2014 18:06, Remi Collet wrote: > >> >However, I think we should stop including features in our patch >>> >releases. I've heard a few others express similar sentiment, but >>> >it may have been more targeted at what we are allowing f

Re: [PHP-DEV] Feature: use Posix ACL for FPM socket

2014-11-30 Thread Rowan Collins
On 30/11/2014 18:06, Remi Collet wrote: >However, I think we should stop including features in our patch >releases. I've heard a few others express similar sentiment, but >it may have been more targeted at what we are allowing for "bug >fixes" in patch releases. Anyway, that's my input. Yes, I'm

Re: [PHP-DEV] Feature: use Posix ACL for FPM socket

2014-11-30 Thread Remi Collet
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Le 30/11/2014 16:34, Levi Morrison a écrit : >> This seems to be a small self contained feature. I'd like to be >> able to implement this in 5.6+ >> >> Is a RFC needed ? > > Is it possible for the ACL header to be in another location? Patch refreshe

Re: [PHP-DEV] Feature: use Posix ACL for FPM socket

2014-11-30 Thread Levi Morrison
> This seems to be a small self contained feature. > I'd like to be able to implement this in 5.6+ > > Is a RFC needed ? Is it possible for the ACL header to be in another location? That's the only potential issue I can see with the patch itself. However, I think we should stop including features

Re: [PHP-DEV] Feature: use Posix ACL for FPM socket

2014-11-30 Thread Remi Collet
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Le 30/11/2014 10:35, Rowan Collins a écrit : > Nit-picking, but I always find it awkward when two variable names > differ only by an "s" - too easy to mistake one for the other, > misread (or miswrite) documentation, etc. So perhaps > listen.acl_users

Re: [PHP-DEV] Feature: use Posix ACL for FPM socket

2014-11-30 Thread Rowan Collins
On 30 November 2014 08:44:08 GMT, Remi Collet wrote: >-BEGIN PGP SIGNED MESSAGE- >Hash: SHA1 > >Hi, > >Please see and comment on https://bugs.php.net/68526 > >In this proposal, this is an optional feature: > >- - new build option: --with-fpm-acl > >=> no change for standard build > >- - ne

[PHP-DEV] Feature: use Posix ACL for FPM socket

2014-11-30 Thread Remi Collet
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi, Please see and comment on https://bugs.php.net/68526 In this proposal, this is an optional feature: - - new build option: --with-fpm-acl => no change for standard build - - new config options: listen.users and listen.groups => no change for e