Re: [PHP-DEV] Faster zend sorting implementation

2015-01-14 Thread Dmitry Stogov
IR - Instruction Retired. We measure them using callgrind to analyze micro-improvements. See https://wiki.php.net/phpng#performance_evaluation for more details. Thanks. Dmitry. On Wed, Jan 14, 2015 at 5:56 PM, Alexander Kurilo wrote: > Hi Xinchen, > >> my draft patch (which already get 0

Re: [PHP-DEV] Faster zend sorting implementation

2015-01-14 Thread Alexander Kurilo
Hi Xinchen, my draft patch (which already get 0.1% IRs reduce in wordpress) could you or anyone else help me understand what IR stands for? Thanks in advance. -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-DEV] Faster zend sorting implementation

2015-01-10 Thread Pierre Joye
On Mon, Jan 5, 2015 at 10:12 AM, David Zuelke wrote: > This sounds reasonable, because given how the sort is *not* stable, there > will be other cases (totally made up, but let's say ["a", "o", "O"]) where > the swap does *not* happen. Consistency, and thus a stable sort, is better. > > But you'

Re: [PHP-DEV] Faster zend sorting implementation

2015-01-10 Thread Yasuo Ohgaki
Hi all, On Wed, Jan 7, 2015 at 12:14 AM, David Zuelke wrote: > > I am not sure about that. Introducing a not easy to catch BC break for > > 0.1% gain on function (or even for the whole app) is not very > > appealing. > > > > However, there is nothing in the documentation actually describing how

Re: [PHP-DEV] Faster zend sorting implementation

2015-01-06 Thread David Zuelke
On 06.01.2015, at 05:42, Pierre Joye wrote: > I am not sure about that. Introducing a not easy to catch BC break for > 0.1% gain on function (or even for the whole app) is not very > appealing. > > However, there is nothing in the documentation actually describing how > it works and there are cl

Re: [PHP-DEV] Faster zend sorting implementation

2015-01-05 Thread Pierre Joye
hi :) On Mon, Jan 5, 2015 at 9:08 AM, Xinchen Hui wrote: > Hey: > > I was working on zend_qsort improvement. but I got a problem need > to be disscussed with you fist.. > > as we know, previously zend_qsort is not a stable sorting algo. > > my draft patch (which already get 0.1% I

Re: [PHP-DEV] Faster zend sorting implementation

2015-01-05 Thread Adam Harvey
On 5 January 2015 at 18:39, Xinchen Hui wrote: > On Tue, Jan 6, 2015 at 2:04 AM, Tim Düsterhus wrote: >> On 05.01.2015 18:08, Xinchen Hui wrote: >>> do you think such BC break is acceptable? or I still need a RFC? :< >>> >> >> Chiming in as a pure userland developer. The documentation already

Re: [PHP-DEV] Faster zend sorting implementation

2015-01-05 Thread Xinchen Hui
On Tue, Jan 6, 2015 at 2:04 AM, Tim Düsterhus wrote: > On 05.01.2015 18:08, Xinchen Hui wrote: >> do you think such BC break is acceptable? or I still need a RFC? :< >> > > Chiming in as a pure userland developer. The documentation already states: > >> Note: Like most PHP sorting functions, so

Re: [PHP-DEV] Faster zend sorting implementation

2015-01-05 Thread Xinchen Hui
On Tue, Jan 6, 2015 at 2:12 AM, David Zuelke wrote: > This sounds reasonable, because given how the sort is *not* stable, there > will be other cases (totally made up, but let's say ["a", "o", "O"]) where > the swap does *not* happen. Consistency, and thus a stable sort, is better. yeah, I also

Re: [PHP-DEV] Faster zend sorting implementation

2015-01-05 Thread Tim Düsterhus
Sorry if someone receives this reply twice. I sent it by a different alias by accident and apparently the sender confirmation does not work properly. On 05.01.2015 18:08, Xinchen Hui wrote: > do you think such BC break is acceptable? or I still need a RFC? > Chiming in as a pure userland deve

Re: [PHP-DEV] Faster zend sorting implementation

2015-01-05 Thread Tim Düsterhus
On 05.01.2015 18:08, Xinchen Hui wrote: > do you think such BC break is acceptable? or I still need a RFC? :< > Chiming in as a pure userland developer. The documentation already states: > Note: Like most PHP sorting functions, sort() uses an implementation of » Quicksort. The pivot is chose

Re: [PHP-DEV] Faster zend sorting implementation

2015-01-05 Thread David Zuelke
This sounds reasonable, because given how the sort is *not* stable, there will be other cases (totally made up, but let's say ["a", "o", "O"]) where the swap does *not* happen. Consistency, and thus a stable sort, is better. But you're saying your patch is "kind of a" stable sorting algo, so is

[PHP-DEV] Faster zend sorting implementation

2015-01-05 Thread Xinchen Hui
Hey: I was working on zend_qsort improvement. but I got a problem need to be disscussed with you fist.. as we know, previously zend_qsort is not a stable sorting algo. my draft patch (which already get 0.1% IRs reduce in wordpress) is kindof a stable sorting algo, you can find it