Andrey,
I compiled with "--enable-debug" already (but did it
again just to make sure). It works fine, with no report of
leaks. Did I miss something?
Jani: You're absolutely right about the comments; sorry
about that!
Otherwise, is the patch OK to be committed?
Paul
--
Quoting
Hi Paul,
may you compile your PHP binary with --enable-debug and after that run your
sample scrit for once. See if there are leaks.
Andrey
Quoting Paul Hudson <[EMAIL PROTECTED]>:
> Er, either the php-internals MARC archive doesn't show all attachments, or
> my diff file got stripped en
Hi,
as Derick stated 2 days ago, the problem is not in the extension but in the
MIME header. The attachment must be text/plain.
Andrey
Quoting Paul Hudson <[EMAIL PROTECTED]>:
> Er, either the php-internals MARC archive doesn't show all attachments, or
> my diff file got stripped en rou
Quickly checked out the patch and first thing to catch my eye
was the use of '//' comments. That's a big no-no. (this is not C++)
Please read the CODING_STANDARDS couple of times. :)
(Use of these C++ comments causes compile failure with some compilers)
--Jani
Er, either the php-internals MARC archive doesn't show all attachments, or
my diff file got stripped en route for not having a .txt extension. I've
attached it again, just to make sure.
Paul
--
-Original Message-
From: Paul Hudson [mailto:[EMAIL PROTECTED]
Sent: 10 February 2004 00:30