Re: [PHP-DEV] Excess arguments for internal functions

2018-07-03 Thread Stanislav Malyshev
Hi! > IMO, we should go the other way. Deprecate excess args in userspace > functions (making them an error in 8.0). We've had formal variadics > in userspace for a long time (5.5 IIRC), this is a solvable problem. I think it's premature. We do have variadics, since 5.6 (https://github.com/php/

Re: [PHP-DEV] Excess arguments for internal functions

2018-07-03 Thread Sara Golemon
On Tue, Jul 3, 2018 at 5:11 AM, Nikita Popov wrote: > I'd go for master only as it's technically BC breaking. > Ditto this. > Some people have plans to get rid of the warning/error on too many > arguments to internal functions to make them consistent with user > functions, so maybe this will beco

Re: [PHP-DEV] Excess arguments for internal functions

2018-07-03 Thread Nikita Popov
On Mon, Jul 2, 2018 at 11:45 PM, Christoph M. Becker wrote: > On 02.07.2018 at 23:16, Nikita Popov wrote: > > > On Mon, Jul 2, 2018 at 11:00 PM, Christoph M. Becker > > wrote: > > > >> Is there any particular reason why internal functions raise a warning/an > >> error regarding excess arguments,

Re: [PHP-DEV] Excess arguments for internal functions

2018-07-02 Thread Christoph M. Becker
On 02.07.2018 at 23:16, Nikita Popov wrote: > On Mon, Jul 2, 2018 at 11:00 PM, Christoph M. Becker > wrote: > >> Is there any particular reason why internal functions raise a warning/an >> error regarding excess arguments, unless they are not supposed to >> receive any arguments at all? In other

Re: [PHP-DEV] Excess arguments for internal functions

2018-07-02 Thread Nikita Popov
On Mon, Jul 2, 2018 at 11:00 PM, Christoph M. Becker wrote: > Hi! > > Is there any particular reason why internal functions raise a warning/an > error regarding excess arguments, unless they are not supposed to > receive any arguments at all? In other words, why don't we use > ZEND_PARSE_PARAMET

[PHP-DEV] Excess arguments for internal functions

2018-07-02 Thread Christoph M. Becker
Hi! Is there any particular reason why internal functions raise a warning/an error regarding excess arguments, unless they are not supposed to receive any arguments at all? In other words, why don't we use ZEND_PARSE_PARAMETERS_NONE() (except for net_get_interfaces())? -- Christoph M. Becker -