Re: [PHP-DEV] Enforcing final in traits

2012-05-05 Thread Nikita Popov
On Sat, May 5, 2012 at 1:38 AM, Stefan Marr wrote: > > On 04 May 2012, at 21:46, Hannes Magnusson wrote: > >> On Fri, May 4, 2012 at 8:30 PM, Scott MacVicar wrote: >>> This caused a few bugs for us / confusion. The final keyword is accepted >>> inside a trait but it the class also defines a meth

Re: [PHP-DEV] Enforcing final in traits

2012-05-04 Thread Stefan Marr
On 04 May 2012, at 21:46, Hannes Magnusson wrote: > On Fri, May 4, 2012 at 8:30 PM, Scott MacVicar wrote: >> This caused a few bugs for us / confusion. The final keyword is accepted >> inside a trait but it the class also defines a method without the final >> keyword this takes precedence. Th

Re: [PHP-DEV] Enforcing final in traits

2012-05-04 Thread Hannes Magnusson
On Fri, May 4, 2012 at 8:30 PM, Scott MacVicar wrote: > This caused a few bugs for us / confusion. The final keyword is accepted > inside a trait but it the class also defines a method without the final > keyword this takes precedence. > it also ignores visibility abstract and static.. I thoug

[PHP-DEV] Enforcing final in traits

2012-05-04 Thread Scott MacVicar
This caused a few bugs for us / confusion. The final keyword is accepted inside a trait but it the class also defines a method without the final keyword this takes precedence. Two solutions: Enforce final when a trait defines - https://whisky.macvicar.net/patches/0001-If-a-trait-declares-a-meth