Re: [PHP-DEV] Eligibility of array_key_exists() optimization for 7.3

2018-08-08 Thread Levi Morrison
On Wed, Aug 8, 2018 at 12:50 PM Sara Golemon wrote: > > On Wed, Aug 8, 2018 at 12:11 PM, Michael Moravec wrote: > > Do you think this optimization could still go into 7.3 so the PHP ecosystem > > could benefit from this improvement (possibly could be reverted in case of > > issues)? > > > My vote

Re: [PHP-DEV] Eligibility of array_key_exists() optimization for 7.3

2018-08-08 Thread Sara Golemon
On Wed, Aug 8, 2018 at 12:11 PM, Michael Moravec wrote: > Do you think this optimization could still go into 7.3 so the PHP ecosystem > could benefit from this improvement (possibly could be reverted in case of > issues)? > My vote is no. It's an optimization and optimizations are yay, but featur

[PHP-DEV] Eligibility of array_key_exists() optimization for 7.3

2018-08-08 Thread Michael Moravec
Hi, there are some questions whether PR #3360 (Implement ZEND_ARRAY_KEY_EXISTS opcode to speed up array_key_exists()) [1] could go into 7.3.0beta2 or not. This PR adds new opcode, but also significantly improves performance of array_key_exists(), to the point that it becomes faster than isset().