Re: [PHP-DEV] EX(scope) removing

2014-11-27 Thread Dmitry Stogov
Yes, we may store EX(called_scope) in EX(This).value.ce and set another type and/or flag(s). But it shouldn't slowdown $this access in _get_obj_zval_ptr_unused() and other often used functions. If it's possible, we may try to merge, if not, it doesn't make sense. Thanks. Dmitry. On Thu, Nov 27, 2

Re: [PHP-DEV] EX(scope) removing

2014-11-27 Thread Levi Morrison
On Thu, Nov 27, 2014 at 12:59 PM, Levi Morrison wrote: >> - try to merge EX(called_scope) and EX(This). Only one of them matters. > > We could use the void *ptr in a zval (or add it to the available types > in the union) and add another flag for zval type. Anyone have an > objection with that? I

Re: [PHP-DEV] EX(scope) removing

2014-11-27 Thread Levi Morrison
> - try to merge EX(called_scope) and EX(This). Only one of them matters. We could use the void *ptr in a zval (or add it to the available types in the union) and add another flag for zval type. Anyone have an objection with that? -- PHP Internals - PHP Runtime Development Mailing List To unsubs

Re: [PHP-DEV] EX(scope) removing

2014-11-27 Thread Dmitry Stogov
Thanks. Probably, I'll commit it tomorrow. Dmitry. On Thu, Nov 27, 2014 at 9:09 PM, Matteo Beccati wrote: > Hi Dmitry, > > On 27/11/2014 18:27, Dmitry Stogov wrote: > >> Could you please take a look into the patch that removes EX(scope) >> https://gist.github.com/dstogov/5ad50d582346385d587e >>

Re: [PHP-DEV] EX(scope) removing

2014-11-27 Thread Matteo Beccati
Hi Dmitry, On 27/11/2014 18:27, Dmitry Stogov wrote: Could you please take a look into the patch that removes EX(scope) https://gist.github.com/dstogov/5ad50d582346385d587e All phpt tests are passed, but I'm not completely sure about one line - https://gist.github.com/dstogov/5ad50d582346385d58

[PHP-DEV] EX(scope) removing

2014-11-27 Thread Dmitry Stogov
Hi, I'm working on call/return sequence optimization. As part of this work I'm minimizing the size of call frame (zend_execute_data) and number of read/write operations on call/return. Could you please take a look into the patch that removes EX(scope) https://gist.github.com/dstogov/5ad50d5823463