[PHP-DEV] doc comment patch

2003-03-21 Thread Andrei Zmievski
Andi and Stas, Here is reworked version of doc comment patch. It doesn't store last doc comment in the compiler globals anymore, instead it's returned inside the T_DOC_COMMENT token. I've also modified a couple of rules in the parser to store the doc comment in zend_class_entry and zend_op_array f

Re: [PHP-DEV] Doc comment patch

2003-03-14 Thread Andrei Zmievski
On Fri, 14 Mar 2003, Andi Gutmans wrote: > Let's see what the API for reflection will look like and then discuss the > information we need. Okay. -Andrei http://www.gravitonic.com/ * George Orwell was an optimist. * -- PHP Internals - PHP Runtime Developme

Re: [PHP-DEV] Doc comment patch

2003-03-14 Thread Andi Gutmans
At 09:05 AM 3/14/2003 -0500, Andrei Zmievski wrote: On Fri, 14 Mar 2003, Andi Gutmans wrote: > Hmm. I thought introspection is reflection. It seems I misunderstood. I think that introspection is a superset of reflection. > Are you sure it's worth bloating the engine to hold this extra information?

Re: [PHP-DEV] Doc comment patch

2003-03-14 Thread Andrei Zmievski
On Fri, 14 Mar 2003, Andi Gutmans wrote: > Hmm. I thought introspection is reflection. It seems I misunderstood. I think that introspection is a superset of reflection. > Are you sure it's worth bloating the engine to hold this extra information? It is possible that an extension or a PEAR class c

Re: [PHP-DEV] Doc comment patch

2003-03-14 Thread Andi Gutmans
Hmm. I thought introspection is reflection. It seems I misunderstood. Are you sure it's worth bloating the engine to hold this extra information? Andi At 03:51 PM 3/13/2003 -0500, Andrei Zmievski wrote: Pursuant to the introspection portion of TODO-PHP5, here is a small patch that: - Keeps track o

Re: [PHP-DEV] Doc comment patch

2003-03-13 Thread Marcus Börger
At 22:49 13.03.2003, Andrei Zmievski wrote: On Thu, 13 Mar 2003, Marcus Börger wrote: > >It's a possibility. You basically want to strip the example that I gave > >down to this?: > > > >@name foo > >@param blah string > > Yes, sure :-) I could put the code to strip those out in the scanner, but it

Re: [PHP-DEV] Doc comment patch

2003-03-13 Thread Andrei Zmievski
On Thu, 13 Mar 2003, Marcus Börger wrote: > >That's what Stig told me to use. :) Stig? > > A single space at the end of a line is nothing that helps in a > syntax it makes things only hard to understand and ensures > that you make a lot of mistakes. Well, as long as we don't confuse doc comments

Re: [PHP-DEV] Doc comment patch

2003-03-13 Thread Andrei Zmievski
On Thu, 13 Mar 2003, Marcus Börger wrote: > {NEWLINE}{TABS_AND_SPACES}"*" { > yymore(); > } > > should do the trick You mean ^{TABS_AND_SPACES}"*" /* eat up */? Wouldn't work. -Andrei http://www.gravitonic.com/ "The most exciting phrase to hear

Re: [PHP-DEV] Doc comment patch

2003-03-13 Thread Andrei Zmievski
On Thu, 13 Mar 2003, Marcus Börger wrote: > >It's a possibility. You basically want to strip the example that I gave > >down to this?: > > > >@name foo > >@param blah string > > Yes, sure :-) I could put the code to strip those out in the scanner, but it would slow things down. If it's acceptable

Re: [PHP-DEV] Doc comment patch

2003-03-13 Thread Marcus Börger
At 22:05 13.03.2003, Andrei Zmievski wrote: > 2) Why is it '/' '*' '*' and SPACE? That's what Stig told me to use. :) Stig? A single space at the end of a line is nothing that helps in a syntax it makes things only hard to understand and ensures that you make a lot of mistakes. marcus -- PHP Inte

Re: [PHP-DEV] Doc comment patch

2003-03-13 Thread Marcus Börger
At 22:05 13.03.2003, Andrei Zmievski wrote: > 4) What about removing everything upto '*' if it is the first character > after a new line starts? It's a possibility. You basically want to strip the example that I gave down to this?: @name foo @param blah string {NEWLINE}{TABS_AND_SPACES}"*" {

Re: [PHP-DEV] Doc comment patch

2003-03-13 Thread Marcus Börger
> 4) What about removing everything upto '*' if it is the first character > after a new line starts? It's a possibility. You basically want to strip the example that I gave down to this?: @name foo @param blah string Yes, sure :-) -- PHP Internals - PHP Runtime Development Mailing List To unsubsc

Re: [PHP-DEV] Doc comment patch

2003-03-13 Thread Andrei Zmievski
On Thu, 13 Mar 2003, Marcus Börger wrote: > Great! > > Some questions: > > 1) Will you allow compatibility with doxygen by this: > > +"/** "{NEWLINE} { > + CG(comment_start_line) = CG(zend_lineno); > + BEGIN(ST_DOC_COMMENT); > + yymore(); > +} > + > > changed to: > +("/** "|"/

Re: [PHP-DEV] Doc comment patch

2003-03-13 Thread Marcus Börger
At 21:51 13.03.2003, Andrei Zmievski wrote: Pursuant to the introspection portion of TODO-PHP5, here is a small patch that: - Keeps track of starting/ending line numbers for user functions. - Removes extraneous T_ML_COMMENT token. - Stores the last seen doc comment (JavaDoc style) in the compiler

Re: [PHP-DEV] Doc comment patch

2003-03-13 Thread Andrei Zmievski
I will remember to attach the patch... I will remember to attach the patch... I will remember to attach the patch... I will.. On Thu, 13 Mar 2003, Andrei Zmievski wrote: > Pursuant to the introspection portion of TODO-PHP5, here is a small > patch that: -Andrei

[PHP-DEV] Doc comment patch

2003-03-13 Thread Andrei Zmievski
Pursuant to the introspection portion of TODO-PHP5, here is a small patch that: - Keeps track of starting/ending line numbers for user functions. - Removes extraneous T_ML_COMMENT token. - Stores the last seen doc comment (JavaDoc style) in the compiler globals for future access by the introspec