Re: [PHP-DEV] Deprecate PDO::ATTR_ERRMODE [Proposed RFC]

2023-09-06 Thread Larry Garfield
On Wed, Sep 6, 2023, at 2:53 PM, Kamil Tekiela wrote: >>Do you think there is still demand for such error mode control features? >> >>Personally, I've never seen anyone prefer silent mode, so I think it's worth >>making the drastic change. > > This may be right. There isn't a demand for this in **

Re: [PHP-DEV] Deprecate PDO::ATTR_ERRMODE [Proposed RFC]

2023-09-06 Thread Saki Takamachi
> We may get away with deprecating and removing PDO silent/warning mode because > it's an extension that was introduced in PHP 5 and everyone was on board with > using exception mode. We probably cannot remove silent mode for other > extensions that either mimic older extensions that didn't use

Re: [PHP-DEV] Deprecate PDO::ATTR_ERRMODE [Proposed RFC]

2023-09-06 Thread Kamil Tekiela
>Do you think there is still demand for such error mode control features? > >Personally, I've never seen anyone prefer silent mode, so I think it's worth >making the drastic change. This may be right. There isn't a demand for this in **new** code and I doubt anyone would come forward with a reaso

Re: [PHP-DEV] Deprecate PDO::ATTR_ERRMODE [Proposed RFC]

2023-09-06 Thread Saki Takamachi
> However, if we are going to remove it, it would be nice to have this done > consistently across all bundled extensions. Thank you for confirmation. This is probably not technically difficult, but it does increase the scope of change. However, as you say, the specifications should be unified.

Re: [PHP-DEV] Deprecate PDO::ATTR_ERRMODE [Proposed RFC]

2023-09-06 Thread G. P. B.
On Tue, 29 Aug 2023 at 14:52, Saki Takamachi wrote: > Hi, internals. > > I thought about various things to improve the current situation where > `PDO::ATTR_ERRMODE` is not working very smartly. > > Exceptions may be thrown regardless of the setting of `PDO::ATTR_ERRMODE`. > https://www.php.net/ma

Re: [PHP-DEV] Deprecate PDO::ATTR_ERRMODE [Proposed RFC]

2023-09-05 Thread Saki Takamachi
Does anyone have any opinions regarding this matter? If there is no response after waiting for a certain period of time, I will start preparing an RFC. Saki -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: https://www.php.net/unsub.php

[PHP-DEV] Deprecate PDO::ATTR_ERRMODE [Proposed RFC]

2023-08-29 Thread Saki Takamachi
Hi, internals. I thought about various things to improve the current situation where `PDO::ATTR_ERRMODE` is not working very smartly. Exceptions may be thrown regardless of the setting of `PDO::ATTR_ERRMODE`. https://www.php.net/manual/en/pdo.rollback.php#refsect1-pdo.rollback-errors Another an