Re: [PHP-DEV] Concurrency support for run-tests

2014-09-14 Thread Michael Wallner
On 15 Sep 2014 05:59, "Matt Ficken" wrote: > > In making/merging major changes (like concurrency) the most important thing is to not break that compatibility and dependability: > > Your patch will fail without the /proc filesystem(mac osx?). On Windows, you can check the %NUMBER_OF_PROCESSORS% en

Re: [PHP-DEV] Concurrency support for run-tests

2014-09-14 Thread Matt Ficken
When building PFTT, the PHP Full Test Tool, one goal was maximizing speed so that we would be more likely to frequently Fully test PHP (Full-coverage of many scenarios), and to do that I built it to run tests concurrently... Concurrent/parallel execution can cause breaks that otherwise work with n

Re: [PHP-DEV] Concurrency support for run-tests

2014-09-10 Thread Michael Wallner
On 09/07/14 22:00, Stas Malyshev wrote: > Hi! > >> Having thought a bit about the subject, the heuristic I came up with was to >> 1) do not run tests from the same extension in parallel, and 2) do not run >> tests from certain extensions in parallel (e.g., mysql and pdo_mysql). > > How about ma

Re: [PHP-DEV] Concurrency support for run-tests

2014-07-10 Thread Stas Malyshev
Hi! > I added a CONCURRENCY_GROUP section, see > https://github.com/m6w6/php-src/compare/parallel-run-tests?expand=1 > > If the next test to execute is in the same CONCURRENCY_GROUP as one > which is already/still running, it will be pushed back. > > So tests with f.e. listening servers could u

Re: [PHP-DEV] Concurrency support for run-tests

2014-07-10 Thread Michael Wallner
On Wed 09 Jul 2014 22:00:49 CEST, Stas Malyshev wrote: > Hi! > >> Having thought a bit about the subject, the heuristic I came up with was to >> 1) do not run tests from the same extension in parallel, and 2) do not run >> tests from certain extensions in parallel (e.g., mysql and pdo_mysql). Heur

Re: [PHP-DEV] Concurrency support for run-tests

2014-07-09 Thread Stas Malyshev
Hi! > Having thought a bit about the subject, the heuristic I came up with was to > 1) do not run tests from the same extension in parallel, and 2) do not run > tests from certain extensions in parallel (e.g., mysql and pdo_mysql). How about making it a whitelist? For tests/extensions we know i

Re: [PHP-DEV] Concurrency support for run-tests

2014-07-09 Thread Nuno Lopes
On Mon, Jul 7, 2014 at 6:53 AM, Michael Wallner wrote: I also have a patch for run-tests sitting around for quite some time, which adds concurrent test execution support. I already fixed a lot of non re-entrant tests in the past, but there might still be quite some of them. HHVM uses PHP's

Re: [PHP-DEV] Concurrency support for run-tests

2014-07-07 Thread Pierre Joye
On Tue, Jul 8, 2014 at 8:02 AM, Michael Wallner wrote: >> About the need of a flag for the tests, it would be useful as well. >> Many tests can't be in run in parallel, like many mysql tests (or >> other databases f.e.). > > > Why can't those tests use unique (to them) names? mysql f.e. initiali

Re: [PHP-DEV] Concurrency support for run-tests

2014-07-07 Thread Michael Wallner
On 7 July 2014 19:13, Pierre Joye wrote: > On Mon, Jul 7, 2014 at 5:07 PM, Laruence wrote: > > Hey: > > > > On Mon, Jul 7, 2014 at 9:53 PM, Michael Wallner wrote: > >> Hi! > >> > >> I also have a patch for run-tests sitting around for quite some time, > which > >> adds concurrent test execution

Re: [PHP-DEV] Concurrency support for run-tests

2014-07-07 Thread Michael Wallner
On 7 July 2014 17:17, Ferenc Kovacs wrote: > > > > On Mon, Jul 7, 2014 at 3:53 PM, Michael Wallner wrote: > >> Hi! >> >> I also have a patch for run-tests sitting around for quite some time, >> which adds concurrent test execution support. I already fixed a lot of non >> re-entrant tests in the

Re: [PHP-DEV] Concurrency support for run-tests

2014-07-07 Thread Michael Wallner
On 7 July 2014 17:07, Laruence wrote: > Hey: > > On Mon, Jul 7, 2014 at 9:53 PM, Michael Wallner wrote: > > Hi! > > > > I also have a patch for run-tests sitting around for quite some time, > which > > adds concurrent test execution support. I already fixed a lot of non > > re-entrant tests in t

Re: [PHP-DEV] Concurrency support for run-tests

2014-07-07 Thread Pierre Joye
On Mon, Jul 7, 2014 at 5:07 PM, Laruence wrote: > Hey: > > On Mon, Jul 7, 2014 at 9:53 PM, Michael Wallner wrote: >> Hi! >> >> I also have a patch for run-tests sitting around for quite some time, which >> adds concurrent test execution support. I already fixed a lot of non >> re-entrant tests in

Re: [PHP-DEV] Concurrency support for run-tests

2014-07-07 Thread Sara Golemon
On Mon, Jul 7, 2014 at 6:53 AM, Michael Wallner wrote: > I also have a patch for run-tests sitting around for quite some time, which > adds concurrent test execution support. I already fixed a lot of non > re-entrant tests in the past, but there might still be quite some of them. > HHVM uses PHP's

Re: [PHP-DEV] Concurrency support for run-tests

2014-07-07 Thread Ferenc Kovacs
On Mon, Jul 7, 2014 at 3:53 PM, Michael Wallner wrote: > Hi! > > I also have a patch for run-tests sitting around for quite some time, > which adds concurrent test execution support. I already fixed a lot of non > re-entrant tests in the past, but there might still be quite some of them. > > Test

Re: [PHP-DEV] Concurrency support for run-tests

2014-07-07 Thread Laruence
Hey: On Mon, Jul 7, 2014 at 9:53 PM, Michael Wallner wrote: > Hi! > > I also have a patch for run-tests sitting around for quite some time, which > adds concurrent test execution support. I already fixed a lot of non > re-entrant tests in the past, but there might still be quite some of them. > >

Re: [PHP-DEV] Concurrency support for run-tests

2014-07-07 Thread Andrea Faulds
On 7 Jul 2014, at 15:36, Michael Wallner wrote: > Hm... didn't think of that, seems overly complex. What would actually need > the singularity of the universe? :) I don’t think it’d be difficult. It wouldn’t mean you can’t run tests alongside it, just that you can’t run it concurrently with a

Re: [PHP-DEV] Concurrency support for run-tests

2014-07-07 Thread Laruence
On Mon, Jul 7, 2014 at 9:53 PM, Michael Wallner wrote: > Hi! > > I also have a patch for run-tests sitting around for quite some time, which > adds concurrent test execution support. I already fixed a lot of non > re-entrant tests in the past, but there might still be quite some of them. > > Tests

Re: [PHP-DEV] Concurrency support for run-tests

2014-07-07 Thread Michael Wallner
Hi Andrea! On 7 July 2014 15:56, Andrea Faulds wrote: > > On 7 Jul 2014, at 14:53, Michael Wallner wrote: > > I also have a patch for run-tests sitting around for quite some time, > which adds concurrent test execution support. I already fixed a lot of non > re-entrant tests in the past, but t

Re: [PHP-DEV] Concurrency support for run-tests

2014-07-07 Thread Andrea Faulds
On 7 Jul 2014, at 14:53, Michael Wallner wrote: > I also have a patch for run-tests sitting around for quite some time, which > adds concurrent test execution support. I already fixed a lot of non > re-entrant tests in the past, but there might still be quite some of them. Did you, or will you

[PHP-DEV] Concurrency support for run-tests

2014-07-07 Thread Michael Wallner
Hi! I also have a patch for run-tests sitting around for quite some time, which adds concurrent test execution support. I already fixed a lot of non re-entrant tests in the past, but there might still be quite some of them. Tests in ./Zend take 8 seconds instead of 30 on my box. Please find the