> De : Pierre Joye [mailto:pierre@gmail.com]
>
> Even better than a server side hook, far less intrusive and rejecting
> a commit when CS are broken before it even gets applied locally sounds
> like the best solution so far.
If it is technically possible, I think we need both.
Local-side pre
On Tue, Jan 6, 2015 at 3:33 AM, Nikita Popov wrote:
> On Tue, Jan 6, 2015 at 12:26 PM, Derick Rethans wrote:
>
>> On Tue, 6 Jan 2015, Nikita Popov wrote:
>>
>> > On Mon, Jan 5, 2015 at 11:58 PM, Stanislav Malyshev > >
>> > wrote:
>> >
>> > > The code in the PHP source repo has a lot of random dan
On Tue, Jan 6, 2015 at 12:26 PM, Derick Rethans wrote:
> On Tue, 6 Jan 2015, Nikita Popov wrote:
>
> > On Mon, Jan 5, 2015 at 11:58 PM, Stanislav Malyshev >
> > wrote:
> >
> > > The code in the PHP source repo has a lot of random dangling
> > > whitespace at the end of lines, which looks sloppy
On Tue, 6 Jan 2015, Nikita Popov wrote:
> On Mon, Jan 5, 2015 at 11:58 PM, Stanislav Malyshev
> wrote:
>
> > The code in the PHP source repo has a lot of random dangling
> > whitespace at the end of lines, which looks sloppy and produces some
> > weird effects in diffs because some editors aut
On Mon, Jan 5, 2015 at 11:48 PM, Pierre Joye wrote:
> On Mon, Jan 5, 2015 at 11:42 PM, Jacob Bednarz
> wrote:
>> Hey
>>
>>> That reminds me something I was wondering, would it be possible to
>>> have a kind of CS check on push? :)
>>
>>
>> Yep - PHPCS[1] is quite good, easy to configure and has
I did not PHPCS supports C. Or am I missing something?
Nope, you are spot on :) - I read this as "let's clean up our
repositories" not just php-src (which reading back through was my
misinterpretation).
Do you have a tool in mind? I see there are a few like indent[1],
uncrustify[2] and as
On Mon, Jan 5, 2015 at 11:42 PM, Jacob Bednarz wrote:
> Hey
>
>> That reminds me something I was wondering, would it be possible to
>> have a kind of CS check on push? :)
>
>
> Yep - PHPCS[1] is quite good, easy to configure and has good editor
> integrations in the community. The automated code s
Hey
That reminds me something I was wondering, would it be possible to
have a kind of CS check on push? :)
Yep - PHPCS[1] is quite good, easy to configure and has good editor
integrations in the community. The automated code standards check can be
achieved using git-hooks[2] which is already
On Mon, Jan 5, 2015 at 2:58 PM, Stanislav Malyshev wrote:
> Hi!
>
> The code in the PHP source repo has a lot of random dangling whitespace
> at the end of lines, which looks sloppy and produces some weird effects
> in diffs because some editors auto-clean it and some do not. I'd like to
> clean i
Hey Stas,
> On 5 Jan 2015, at 22:58, Stanislav Malyshev wrote:
>
> The code in the PHP source repo has a lot of random dangling whitespace
> at the end of lines, which looks sloppy and produces some weird effects
> in diffs because some editors auto-clean it and some do not. I'd like to
> clean
On 05/01/15 22:58, Stanislav Malyshev wrote:
> So, I'd like to ask if there are any objections to such cleanup? If not,
> then I'll do it, probably next weekend.
The bigger question is perhaps how they got added in the first place.
(And it's a bit like replacing all the tabs with spaces.) I've bee
On Mon, Jan 5, 2015 at 11:58 PM, Stanislav Malyshev
wrote:
> Hi!
>
> The code in the PHP source repo has a lot of random dangling whitespace
> at the end of lines, which looks sloppy and produces some weird effects
> in diffs because some editors auto-clean it and some do not. I'd like to
> clean
Hi!
The code in the PHP source repo has a lot of random dangling whitespace
at the end of lines, which looks sloppy and produces some weird effects
in diffs because some editors auto-clean it and some do not. I'd like to
clean it up (it's easy to do automatically) in master, but this produces
a bi
13 matches
Mail list logo
