Re: [PHP-DEV] Change the signature of odbc_connect

2023-10-25 Thread Saki Takamachi
Hi, Máté Thank you for your feedback! After seeing your email, I decided to start implementing it. I have already created a pull request for a bug fix that does not require a signature change, and I plan to update it. Regards. Saki -- PHP Internals - PHP Runtime Development Mailing List To un

Re: [PHP-DEV] Change the signature of odbc_connect

2023-10-24 Thread Máté Kocsis
Hi Saki, In my opinion, this is a simple and useful bugfix + nice consistency improvement with negligible backward compatibility break, so I don't think it needs any vote. Regards, Máté

Re: [PHP-DEV] Change the signature of odbc_connect

2023-10-22 Thread Saki Takamachi
Hi Do you think this requires an RFC in the first place? If there are no objections after waiting for a while, I will submit a pull request without creating an RFC. Regards. Saki -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: https://www.php.net/unsub.php

[PHP-DEV] Change the signature of odbc_connect

2023-10-11 Thread Saki Takamachi
Hi, internals I'm currently working on renovating odbc_connect and odbc_pconnect. https://github.com/php/php-src/pull/12306 As a problem came up, I'm planning to create an RFC. I explain the problem briefly. In addition to the dsn, these functions have a credential argument. They are required