RE: [PHP-DEV] C++ and FAST_ZPP macros

2017-12-19 Thread Anatol Belski
> -Original Message- > From: p...@golemon.com [mailto:p...@golemon.com] On Behalf Of Sara > Golemon > Sent: Tuesday, December 19, 2017 10:05 PM > To: Anatol Belski > Cc: PHP internals > Subject: Re: [PHP-DEV] C++ and FAST_ZPP macros > > On Tue, Dec 19, 201

Re: [PHP-DEV] C++ and FAST_ZPP macros

2017-12-19 Thread Sara Golemon
On Tue, Dec 19, 2017 at 3:29 PM, Anatol Belski wrote: >> As the blog post notes, it's a simple matter to work around the bug in >> extension >> code (indeed, an extension can simply opt to not use FAST_ZPP). On the other >> hand, the fix is pretty basic, and existing functionality of the default

RE: [PHP-DEV] C++ and FAST_ZPP macros

2017-12-19 Thread Anatol Belski
Hi Sara, > -Original Message- > From: p...@golemon.com [mailto:p...@golemon.com] On Behalf Of Sara > Golemon > Sent: Monday, December 18, 2017 8:44 PM > To: PHP internals > Subject: [PHP-DEV] C++ and FAST_ZPP macros > > This blog post came across my twitter

Re: [PHP-DEV] C++ and FAST_ZPP macros

2017-12-18 Thread Levi Morrison
On Mon, Dec 18, 2017 at 2:31 PM, Sara Golemon wrote: > On Mon, Dec 18, 2017 at 4:11 PM, Sara Golemon wrote: >> On Mon, Dec 18, 2017 at 3:38 PM, Levi Morrison wrote: Thoughts? If I don't hear anything in a week, I'll just apply to 7.1 and merge up. >>> Is our macro `#define Z_EXPE

Re: [PHP-DEV] C++ and FAST_ZPP macros

2017-12-18 Thread Sara Golemon
On Mon, Dec 18, 2017 at 4:11 PM, Sara Golemon wrote: > On Mon, Dec 18, 2017 at 3:38 PM, Levi Morrison wrote: >>> Thoughts? If I don't hear anything in a week, I'll just apply to 7.1 >>> and merge up. >>> >> Is our macro `#define Z_EXPECTED_TYPE_STR(id, str) str,` ever used? If >> so there might

Re: [PHP-DEV] C++ and FAST_ZPP macros

2017-12-18 Thread Sara Golemon
On Mon, Dec 18, 2017 at 3:38 PM, Levi Morrison wrote: >> Thoughts? If I don't hear anything in a week, I'll just apply to 7.1 >> and merge up. >> > Is our macro `#define Z_EXPECTED_TYPE_STR(id, str) str,` ever used? If > so there might be a change in perceived behavior because the first > entry p

Re: [PHP-DEV] C++ and FAST_ZPP macros

2017-12-18 Thread Levi Morrison
On Mon, Dec 18, 2017 at 12:43 PM, Sara Golemon wrote: > This blog post came across my twitter today and it's certainly legit. > https://cismon.net/2017/12/18/Fast-ZPP-s-Incompatibility-with-CPP/ > > I tossed together this quick and dirty fix (and tested it with a > simple C++ extension), but I wan

[PHP-DEV] C++ and FAST_ZPP macros

2017-12-18 Thread Sara Golemon
This blog post came across my twitter today and it's certainly legit. https://cismon.net/2017/12/18/Fast-ZPP-s-Incompatibility-with-CPP/ I tossed together this quick and dirty fix (and tested it with a simple C++ extension), but I wanted to get a read on what branch folks think it should be applie