Re: [PHP-DEV] Binary searches

2006-06-07 Thread Nuno Lopes
Yesterday some my colleagues were precisely discussing that issue.. I recommend you to submit the patches upstream (to both pcre and libxmlrpc authors) instead, as we prefer not to change bundled libraries (for maintenance sake). Nuno - Original Message - Attached is a patch which

Re: [PHP-DEV] Binary searches

2006-06-07 Thread Sebastian Bergmann
Antony Dovgal wrote: > Please elaborate. > What exactly are you fixing and how to reproduce it? http://googleresearch.blogspot.com/2006/06/extra-extra-read-all-about-it-nearly.html -- Sebastian Bergmann http://www.sebastian-bergmann.de/ GnuPG Key: 0xB85B5D69 / 27A7 2B14 09E4

Re: [PHP-DEV] Binary searches

2006-06-07 Thread Antony Dovgal
On 07.06.2006 03:06, john wrote: Attached is a patch which addresses array indices being out of bounds in pcre and libxmlrpc binary searches. Please elaborate. What exactly are you fixing and how to reproduce it? Index:

[PHP-DEV] Binary searches

2006-06-06 Thread john
Attached is a patch which addresses array indices being out of bounds in pcre and libxmlrpc binary searches. John Index: ext/pcre/pcrelib/pcre_get.c === RCS file: /repository/php-src/ext/pcre/pcrelib/pcre_get.c,v retrieving revision