Re: [PHP-DEV] Apache builds

2008-07-18 Thread Steph Fox
I've committed a fix now and it compiles correctly, I also removed the two warnings. You're the man :) - Steph -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-DEV] Apache builds

2008-07-18 Thread Scott MacVicar
I've committed a fix now and it compiles correctly, I also removed the two warnings. Scott Steph Fox wrote: Scott, Isn't it just a case of rewriting php_apache_fteller_stream() to use the new API? I think we can actually just add an fsizer function and use apr_brigade_length(pbb->bb);

Re: [PHP-DEV] Apache builds

2008-07-18 Thread Pierre Joye
On Fri, Jul 18, 2008 at 1:10 PM, Steph Fox <[EMAIL PROTECTED]> wrote: > In that case, wouldn't it be nice if Scott were allowed to reply to my > question without all this barracking from you? Nobody's interested in your personal vendettas. We are here to work and get things done, not to read thin

Re: [PHP-DEV] Apache builds

2008-07-18 Thread Steph Fox
Scott, Isn't it just a case of rewriting php_apache_fteller_stream() to use the new API? I think we can actually just add an fsizer function and use apr_brigade_length(pbb->bb); I think that's what 'rewriting php_apache_fteller_stream() means ;) Why move it from pbb->total_len? That sho

Re: [PHP-DEV] Apache builds

2008-07-18 Thread Pierre Joye
On Fri, Jul 18, 2008 at 12:34 PM, Steph Fox <[EMAIL PROTECTED]> wrote: > > Pierre, > >> It is not due to re2c introduction but to changes committed only in >> one branch and never merged to HEAD. Then good developers worked in >> HEAD and merged to 5.3 ending with the current mess. > > Y'know, atta

Re: [PHP-DEV] Apache builds

2008-07-18 Thread Scott MacVicar
Steph, Steph Fox wrote: Hi Scott, thanks, John worked on apache2filter and for some reason he only made a change to do with streams on the 5.x branch [1] and never merged his change to head. It means that currently apache2filter works on HEAD but not on PHP 5.3 Ahhh it was 2 years

Re: [PHP-DEV] Apache builds

2008-07-18 Thread Steph Fox
Hi Scott, thanks, John worked on apache2filter and for some reason he only made a change to do with streams on the 5.x branch [1] and never merged his change to head. It means that currently apache2filter works on HEAD but not on PHP 5.3 Ahhh it was 2 years ago in 5_2 branch. I've n

Re: [PHP-DEV] Apache builds

2008-07-18 Thread Steph Fox
Pierre, I have no idea what makes you think that my reply was a personal attack History? Let me rephrase that. Look at the actual commit. - As Scott is working in this area right now, he's volunteered to fix it as soon as possible. In that case, wouldn't it be nice if Scott were allowed

Re: [PHP-DEV] Apache builds

2008-07-18 Thread Scott MacVicar
Hey Steph, John worked on apache2filter and for some reason he only made a change to do with streams on the 5.x branch [1] and never merged his change to head. It means that currently apache2filter works on HEAD but not on PHP 5.3 I've not yet had time to see if there is a way to get a length

Re: [PHP-DEV] Apache builds

2008-07-18 Thread Steph Fox
Pierre, It is not due to re2c introduction but to changes committed only in one branch and never merged to HEAD. Then good developers worked in HEAD and merged to 5.3 ending with the current mess. Y'know, attacking me every time I make a move is counterproductive. In this case, it means that

Re: [PHP-DEV] Apache builds

2008-07-18 Thread Pierre Joye
hi, On Fri, Jul 18, 2008 at 4:38 AM, Steph Fox <[EMAIL PROTECTED]> wrote: > > Hi all, > > I've been struggling a bit with Apache tonight. I'd hoped to send real > patches at the end of it, but... It is not due to re2c introduction but to changes committed only in one branch and never merged to HE

[PHP-DEV] Apache builds

2008-07-17 Thread Steph Fox
Hi all, I've been struggling a bit with Apache tonight. I'd hoped to send real patches at the end of it, but... I got sapi/apache to build by adding a direct include for zend_globals.h to php_apache_http.h. I have no idea why the apache sapi would suddenly want that, I just know it showed n