Re: [PHP-DEV] Add get_mangled_object_properties()

2019-06-06 Thread Marco Pivetta
Provided feedback on the patch: looking good for me, not sure of this needs an RFC or not. On Thu, Jun 6, 2019, 09:53 Nikita Popov wrote: > On Tue, May 14, 2019 at 4:45 PM Nikita Popov wrote: > >> On Tue, May 14, 2019 at 4:37 PM Marco Pivetta wrote: >> >>> >>> On Tue, May 14, 2019 at 4:29 PM B

Re: [PHP-DEV] Add get_mangled_object_properties()

2019-06-06 Thread Nikita Popov
On Tue, May 14, 2019 at 4:45 PM Nikita Popov wrote: > On Tue, May 14, 2019 at 4:37 PM Marco Pivetta wrote: > >> >> On Tue, May 14, 2019 at 4:29 PM Benjamin Morel >> wrote: >> >>> I like the explicitness of the proposal, but only if performance is as >>> good >>> as (array) cast. One of the reas

Re: [PHP-DEV] Add get_mangled_object_properties()

2019-05-14 Thread Nikita Popov
On Tue, May 14, 2019 at 4:37 PM Marco Pivetta wrote: > > On Tue, May 14, 2019 at 4:29 PM Benjamin Morel > wrote: > >> I like the explicitness of the proposal, but only if performance is as >> good >> as (array) cast. One of the reasons we use casting to array in libraries >> is >> not only to ac

Re: [PHP-DEV] Add get_mangled_object_properties()

2019-05-14 Thread Nikita Popov
On Tue, May 14, 2019 at 4:29 PM Benjamin Morel wrote: > I like the explicitness of the proposal, but only if performance is as > good as (array) cast. One of the reasons we use casting to array in > libraries is not only to access all properties at once, but also because > it's fast as it's imple

Re: [PHP-DEV] Add get_mangled_object_properties()

2019-05-14 Thread Marco Pivetta
On Tue, May 14, 2019 at 4:29 PM Benjamin Morel wrote: > I like the explicitness of the proposal, but only if performance is as good > as (array) cast. One of the reasons we use casting to array in libraries is > not only to access all properties at once, but also because it's fast as > it's imple

Re: [PHP-DEV] Add get_mangled_object_properties()

2019-05-14 Thread Benjamin Morel
I like the explicitness of the proposal, but only if performance is as good as (array) cast. One of the reasons we use casting to array in libraries is not only to access all properties at once, but also because it's fast as it's implemented as an opcode and not a function call. Would this function

Re: [PHP-DEV] Add get_mangled_object_properties()

2019-05-14 Thread Steven Wade
> Inspired by the recent discussion on __toArray(), I'd like to propose the > addition of a get_mangled_object_properties() function, implemented in > https://github.com/php/php-src/pull/4163. > > This function returns the mangled object properties (duh...), which matches > the behavior of the (ar

[PHP-DEV] Add get_mangled_object_properties()

2019-05-14 Thread Nikita Popov
Hi internals, Inspired by the recent discussion on __toArray(), I'd like to propose the addition of a get_mangled_object_properties() function, implemented in https://github.com/php/php-src/pull/4163. This function returns the mangled object properties (duh...), which matches the behavior of the