RE: [PHP-DEV] Don't compress empty output with zlib

2009-02-24 Thread Paul Preece
*bump* -Original Message- From: news [mailto:n...@ger.gmane.org] On Behalf Of Edward Z. Yang Sent: 24 February 2009 7:38 am To: internals@lists.php.net Cc: ras...@lerdorf.on.ca; s...@linux.de; z...@zend.com; nicole...@nns.ch Subject: Re: [PHP-DEV] Don't compress empty output with

Re: [PHP-DEV] Don't compress empty output with zlib

2009-02-23 Thread Edward Z. Yang
CC'ed authors of zlib.c Could this patch be applied to PHP_5_2 and further? Index: ext/zlib/zlib.c === RCS file: /repository/php-src/ext/zlib/zlib.c,v retrieving revision 1.183.2.6.2.8 diff -u -r1.183.2.6.2.8 zlib.c --- ext/zlib/zlib

Re: [PHP-DEV] Don't compress empty output with zlib

2009-02-18 Thread Edward Z. Yang
Edward Z. Yang wrote: > The previous patch is wrong (it doesn't handle the flush();flush(); case > well). Here's a better one, although it's 304 specific: Bump? -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-DEV] Don't compress empty output with zlib

2009-02-17 Thread Edward Z. Yang
Edward Z. Yang wrote: > Hello all, I've cooked up a short paonetch for Bug 42362, and would > appreciate comments. The patch turns off zlib compression if there is no > output, to make zlib_compression play more nicely with 304s. The previous patch is wrong (it doesn't handle the flush();flush();

[PHP-DEV] Don't compress empty output with zlib

2009-02-17 Thread Edward Z. Yang
Hello all, I've cooked up a short patch for Bug 42362, and would appreciate comments. The patch turns off zlib compression if there is no output, to make zlib_compression play more nicely with 304s. Cheers, Edward Index: ext/zlib/zlib.c