Re: [PHP-DEV] [VOTE] array_column() function

Hi Ben, On 28 February 2013 01:56, Ben Ramsey wrote: > Sorry. I got sick for a few weeks, and this fell to the bottom of my > priorities list. > > I'm not sure what the next steps are. This was approved by a majority vote. > What do I need to do now to get it into 5.5? > > Thanks, > Ben > The ne

Re: [PHP-DEV] [VOTE] array_column() function

> Please kill that alias. It is pointless to introduce a new function > with an alias for it. > > I killed the alias in this commit: https://github.com/ramsey/php-src/commit/3439a098a0b646ff05d4da9748996214cac39d12 -Ben

Re: [PHP-DEV] [VOTE] array_column() function

On Thu, Feb 28, 2013 at 2:56 AM, Ben Ramsey wrote: > Sorry. I got sick for a few weeks, and this fell to the bottom of my > priorities list. > > I'm not sure what the next steps are. This was approved by a majority vote. > What do I need to do now to get it into 5.5? Please kill that alias. It is

Re: [PHP-DEV] [VOTE] array_column() function

Sorry. I got sick for a few weeks, and this fell to the bottom of my priorities list. I'm not sure what the next steps are. This was approved by a majority vote. What do I need to do now to get it into 5.5? Thanks, Ben On Wed, Feb 27, 2013 at 6:51 AM, Pierre du Plessis wrote: > > On 12 Januar

Re: [PHP-DEV] [VOTE] array_column() function

> On 12 January 2013 00:17, Ben Ramsey wrote: > > I've opened voting for the array_column() function RFC. > > > > You can vote at https://wiki.php.net/rfc/array_column#voting > > > > Regards, > > Ben > > > > The vote has been open for almost three weeks and discussion tailed > off after only a few

Re: [PHP-DEV] [VOTE] array_column() function

Hi Ben, On 12 January 2013 00:17, Ben Ramsey wrote: > I've opened voting for the array_column() function RFC. > > You can vote at https://wiki.php.net/rfc/array_column#voting > > Regards, > Ben > The vote has been open for almost three weeks and discussion tailed off after only a few days here.

Re: [PHP-DEV] [VOTE] array_column() function

On 01/14/2013 10:12 PM, Herman Radtke wrote: If it is called "array_pluck" it should remove the data in question from the original array. (I'm not saying that is a desirable feature here, I'm just saying that makes more sense based on the meaning of the name you seem to prefer.) Why do you think

Re: [PHP-DEV] [VOTE] array_column() function

> If it is called "array_pluck" it should remove the data in question from the > original array. (I'm not saying that is a desirable feature here, I'm just > saying that makes more sense based on the meaning of the name you seem to > prefer.) Why do you think pluck is destructive? In most examples

Re: [PHP-DEV] [VOTE] array_column() function

On 01/14/2013 02:19 PM, Lars Strojny wrote: Hi Ben, Am 14.01.2013 um 23:16 schrieb Pierre Joye : [...] Up to you, but I'd to suggest again to re do the vote and add the naming option, easy, clear, open. I was one of the people changing from yes to no because of the name. I like the functional

Re: [PHP-DEV] [VOTE] array_column() function

On Mon, 14 Jan 2013 23:43:31 +0100, Lars Strojny wrote: - Do you want to include the functionality: yes/no - If you want to include it, which name should it have: array_column/array_pluck ? You said earlier: I was one of the people changing from yes to no because of the name. I like the

Re: [PHP-DEV] [VOTE] array_column() function

It’s quite simple: - Do you want to include the functionality: yes/no - If you want to include it, which name should it have: array_column/array_pluck Am 14.01.2013 um 23:23 schrieb Gustavo Lopes : > On Mon, 14 Jan 2013 23:16:52 +0100, Pierre Joye wrote: > >> On Mon, Jan 14, 2013 at 11:01

Re: [PHP-DEV] [VOTE] array_column() function

On Mon, 14 Jan 2013 23:16:52 +0100, Pierre Joye wrote: On Mon, Jan 14, 2013 at 11:01 PM, Ben Ramsey wrote: I've already removed the array_pluck() alias. Unfortunately, after removing the alias, it appears that some have changed their votes from "yes" to "no," because they preferred the

Re: [PHP-DEV] [VOTE] array_column() function

Hi Ben, Am 14.01.2013 um 23:16 schrieb Pierre Joye : [...] > Up to you, but I'd to suggest again to re do the vote and add the > naming option, easy, clear, open. I was one of the people changing from yes to no because of the name. I like the functionality but I prefer no new array function over

Re: [PHP-DEV] [VOTE] array_column() function

On Mon, Jan 14, 2013 at 11:01 PM, Ben Ramsey wrote: > I've already removed the array_pluck() alias. Unfortunately, after removing > the alias, it appears that some have changed their votes from "yes" to "no," > because they preferred the other function name. > > That said, I'm not going to call f

Re: [PHP-DEV] [VOTE] array_column() function

On 1/14/13 3:49 PM, Pierre Joye wrote: hi! Btw, really willing to have this function but I agree with other here, the alias must go. It makes no sense to introduce a function and an alias to it at the same time. Maybe restart the vote and let choose function name. Options: 1. array_column 2. a

Re: [PHP-DEV] [VOTE] array_column() function

hi! Btw, really willing to have this function but I agree with other here, the alias must go. It makes no sense to introduce a function and an alias to it at the same time. Maybe restart the vote and let choose function name. Options: 1. array_column 2. array_pluck 3. none of them Thanks for yo

Re: [PHP-DEV] [VOTE] array_column() function

Nope, it wasn’t rejected, there was simply no response for a really long time: https://github.com/php/php-src/pull/202 Am 14.01.2013 um 22:06 schrieb Herman Radtke : > On Sat, Jan 12, 2013 at 12:04 AM, Levi Morrison > wrote: >> The real problem here (in my opinion) is that `array_filter` does

Re: [PHP-DEV] [VOTE] array_column() function

On Sat, Jan 12, 2013 at 12:04 AM, Levi Morrison wrote: > The real problem here (in my opinion) is that `array_filter` does not > pass the key information to the callback. If you could do that, you > could select columns that way. I opened a PR with this feature, but it was rejected. -- Herman R

Re: [PHP-DEV] [VOTE] array_column() function

On 12 January 2013 08:17, Ben Ramsey wrote: > I've opened voting for the array_column() function RFC. > > You can vote at https://wiki.php.net/rfc/array_column#voting To be clear, I've voted -1 solely due to the function alias: if this were reproposed with either name (I don't have a strong prefe

Re: [PHP-DEV] [VOTE] array_column() function

On Sat, Jan 12, 2013 at 7:34 AM, Ben Ramsey wrote: > On 1/12/13 9:19 AM, Derick Rethans wrote: > >> I'm liking this, why start with an function alias already when >> introducing a new feature? >> > > I figured this would be a frequent question, and I was right. :-) > > In earlier discussions (Jun

Re: [PHP-DEV] [VOTE] array_column() function

Hi! > I can submit a new pull request against the master branch, if that's > acceptable. This is intended for 5.5. The patch should be against 5.5, I think. 5.5 is in alpha, so adding an isolated function to it is no problem (we're still considering adding a major language feature to it, so func

Re: [PHP-DEV] [VOTE] array_column() function

On Fri, Jan 11, 2013 at 7:17 PM, Ben Ramsey wrote: > I've opened voting for the array_column() function RFC. > > You can vote at https://wiki.php.net/rfc/array_column#voting No voting member, here, but I'd just like to say that I like the function, but I hope the actual implementation will only p

Re: [PHP-DEV] [VOTE] array_column() function

Hi! > Stas, I think you are misrepresenting this a bit. It's not about adding > something "cool looking", it's about adding a feature that solves *this > and many more* problems in a consistent way. A way that does *not* > require to add a new function for every single array manipulation. We alre

Re: [PHP-DEV] [VOTE] array_column() function

Hi! > 2) Developers coming from other languages (Ruby, JavaScript, etc.) will > instantly recognize array_pluck(). It's what they'll be looking for to > do the same thing, but they won't be looking for array_column(). I say nuke the alias :) I like array_column (maybe because English is not my

Re: [PHP-DEV] [VOTE] array_column() function

On 12 January 2013 16:41, Ben Ramsey wrote: > > I must have misread the Git Workflow page of the wiki, which states: > > "A patch will be applied to the oldest possible branch. If the Release > Manager of 5.3 accepts the change, commit it to the 5.3 branch. We will use > regular merging between th

Re: [PHP-DEV] [VOTE] array_column() function

Hi, On 01/12/2013 07:34 AM, Ben Ramsey wrote: 2) Developers coming from other languages (Ruby, JavaScript, etc.) will instantly recognize array_pluck(). It's what they'll be looking for to do the same thing, but they won't be looking for array_column(). -Ben When I have to write JavaScri

Re: [PHP-DEV] [VOTE] array_column() function

Hi Ben, Am 12.01.2013 um 01:17 schrieb Ben Ramsey : > I've opened voting for the array_column() function RFC. > > You can vote at https://wiki.php.net/rfc/array_column#voting I voted yes, but I prefer to call it just array_pluck (no aliases). It’s what underscore.js calls it and my own pet pro

Re: [PHP-DEV] [VOTE] array_column() function

On 1/12/13 10:13 AM, Peter Cowburn wrote: 1. Why is this branch based on 5.3, rather than 5.4 or 5.5? Do you want this to be part of 5.3? The RFC (in particular the vote question) does not make it clear where/when you want this to be added. I mentioned this in another response on this thread. I

Re: [PHP-DEV] [VOTE] array_column() function

On 1/12/13 10:17 AM, Levi Morrison wrote: 1. Why is this branch based on 5.3, rather than 5.4 or 5.5? Do you want this to be part of 5.3? The RFC (in particular the vote question) does not make it clear where/when you want this to be added. Please, this is not a bug or security fix. It does not

Re: [PHP-DEV] [VOTE] array_column() function

On Sat, Jan 12, 2013 at 4:54 PM, Derick Rethans wrote: > > I know that not everyone agrees with that philosophy, but I personally > > don't like to add new features that can be easily covered by more > > general solutions, or features that just represent a hack because the > > more general soluti

Re: [PHP-DEV] [VOTE] array_column() function

> 1. Why is this branch based on 5.3, rather than 5.4 or 5.5? Do you > want this to be part of 5.3? The RFC (in particular the vote question) > does not make it clear where/when you want this to be added. Please, this is not a bug or security fix. It does not belong in 5.3. -- PHP Internals - PH

Re: [PHP-DEV] [VOTE] array_column() function

On 12 January 2013 00:17, Ben Ramsey wrote: > I've opened voting for the array_column() function RFC. > > You can vote at https://wiki.php.net/rfc/array_column#voting > I like the idea of this function, but have a few minor questions re. the current implementation. 1. Why is this branch based on

Re: [PHP-DEV] [VOTE] array_column() function

On 1/11/2013 11:53 PM, Anthony Ferrara wrote: From what I can see this new function doesn't fit any of those three to a significant enough extent. All three are definitely subjective, but I'm leaning towards a no vote because I just don't feel there's enough justification for the new function wh

Re: [PHP-DEV] [VOTE] array_column() function

My .02 cents here... I'm used to array_pluck(), even when I first saw it I was like WTH is that? When you read the description though, 'plucking' is a verb which describes the action the function is taking, while column is a noun and does not describe the action the function is taking. In f

Re: [PHP-DEV] [VOTE] array_column() function

On Sat, 12 Jan 2013, Nikita Popov wrote: > On Sat, Jan 12, 2013 at 6:57 AM, Stas Malyshev wrote: > > > This is a great illustration of different visions we have here. On > > one hand, we have practical, immediate feature that covers a clear > > use case and does not add any constructs or comple

Re: [PHP-DEV] [VOTE] array_column() function

On 1/12/13 9:19 AM, Derick Rethans wrote: I'm liking this, why start with an function alias already when introducing a new feature? I figured this would be a frequent question, and I was right. :-) In earlier discussions (June 2012), when I first introduced array_column(), much of the discuss

Re: [PHP-DEV] [VOTE] array_column() function

On 1/12/13 9:14 AM, Peter Cowburn wrote: The "Status" for this RFC is still "Under discussion" and on the RFC listing page it is the same. Is not changing those two things simply an oversight? It was an oversight. I have corrected it in both places. -- PHP Internals - PHP Runtime Development

Re: [PHP-DEV] [VOTE] array_column() function

On Fri, 11 Jan 2013, Stas Malyshev wrote: > > Voting no, because - even though I like this feature in principle - I think > > it's much better solved by introducing list comprehensions (which cover > > this and many more cases in a consistent and elegant syntax), which is > > something I have plan

Re: [PHP-DEV] [VOTE] array_column() function

On Fri, 11 Jan 2013, Ben Ramsey wrote: > I've opened voting for the array_column() function RFC. > > You can vote at https://wiki.php.net/rfc/array_column#voting I'm liking this, why start with an function alias already when introducing a new feature? cheers, Derick -- PHP Internals - PHP Ru

Re: [PHP-DEV] [VOTE] array_column() function

On 12 January 2013 00:17, Ben Ramsey wrote: > I've opened voting for the array_column() function RFC. > > You can vote at https://wiki.php.net/rfc/array_column#voting > > Regards, > Ben > The "Status" for this RFC is still "Under discussion" and on the RFC listing page it is the same. Is not chan

Re: [PHP-DEV] [VOTE] array_column() function

On Sat, Jan 12, 2013 at 6:57 AM, Stas Malyshev wrote: > Hi! > > > Voting no, because - even though I like this feature in principle - I > think > > it's much better solved by introducing list comprehensions (which cover > > this and many more cases in a consistent and elegant syntax), which is > >

Re: [PHP-DEV] [VOTE] array_column() function

The real problem here (in my opinion) is that `array_filter` does not pass the key information to the callback. If you could do that, you could select columns that way. -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-DEV] [VOTE] array_column() function

On Fri, Jan 11, 2013 at 10:53 PM, Anthony Ferrara wrote: > Stas, > > This is a great illustration of different visions we have here. On one > > hand, we have practical, immediate feature that covers a clear use case > > and does not add any constructs or complexity to the core language and > > ser

Re: [PHP-DEV] [VOTE] array_column() function

Stas, This is a great illustration of different visions we have here. On one > hand, we have practical, immediate feature that covers a clear use case > and does not add any constructs or complexity to the core language and > services immediate need, covering several lines of frequently > encounte

Re: [PHP-DEV] [VOTE] array_column() function

Hi! > Voting no, because - even though I like this feature in principle - I think > it's much better solved by introducing list comprehensions (which cover > this and many more cases in a consistent and elegant syntax), which is > something I have planned for 5.6. This is a great illustration of

Re: [PHP-DEV] [VOTE] array_column() function

On Sat, Jan 12, 2013 at 12:21 AM, Nikita Popov wrote: > Voting no, because - even though I like this feature in principle - I think > it's much better solved by introducing list comprehensions (which cover > this and many more cases in a consistent and elegant syntax), which is > something I have

Re: [PHP-DEV] [VOTE] array_column() function

On Sat, Jan 12, 2013 at 1:36 AM, Matt Pelmear wrote: > That said, I hate function aliases. Can't we have one or the other here, > not both? (array_column() vs array_pluck()) > Agree fully on this part. If this is going to make it, then please, *please* without aliases. array_column() is my prefe

Re: [PHP-DEV] [VOTE] array_column() function

On 01/11/2013 04:17 PM, Ben Ramsey wrote: I've opened voting for the array_column() function RFC. You can vote at https://wiki.php.net/rfc/array_column#voting Regards, Ben +1 I can't vote, but I support this RFC. This is much, much simpler to use and easier to implement than most other th

Re: [PHP-DEV] [VOTE] array_column() function

On Sat, Jan 12, 2013 at 1:17 AM, Ben Ramsey wrote: > I've opened voting for the array_column() function RFC. > > You can vote at > https://wiki.php.net/rfc/**array_column#voting > > Regards, > Ben > Voting no, because - even though I like this featu

[PHP-DEV] [VOTE] array_column() function

I've opened voting for the array_column() function RFC. You can vote at https://wiki.php.net/rfc/array_column#voting Regards, Ben -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php