Re: [PHP-DEV] [VOTE] Strict operators directive

2019-07-09 Thread Stephen Reay
> On 9 Jul 2019, at 17:06, Christian Schneider wrote: > > When you drop the declaration on top of the file the semantics of your > operators suddenly change, e.g. > "42" < "7" > changes from true to false and you get subtle bugs. If you OPT IN to strict operators, the onus is on you to

Re: [PHP-DEV] [VOTE] Strict operators directive

2019-07-09 Thread Arnold Daniels
On Tue, Jul 9, 2019 at 12:22 PM Claude Pache wrote: > > > > Le 9 juil. 2019 à 12:09, Andreas Heigl a écrit : > > > > > > > > Am 09.07.19 um 12:06 schrieb Christian Schneider: > >> Am 09.07.2019 um 11:30 schrieb Marco Pivetta : > >>> I wasn't sure about the full implications of this, but after so

Re: [PHP-DEV] [VOTE] Strict operators directive

2019-07-09 Thread Claude Pache
> Le 9 juil. 2019 à 12:09, Andreas Heigl a écrit : > > > > Am 09.07.19 um 12:06 schrieb Christian Schneider: >> Am 09.07.2019 um 11:30 schrieb Marco Pivetta : >>> I wasn't sure about the full implications of this, but after some thought, >>> the worst that can happen is excessive strictness,

Re: [PHP-DEV] [VOTE] Strict operators directive

2019-07-09 Thread Nikita Popov
re freeze. I would feel a lot better about this if it targeted PHP 8 and the vote was in one month, when we're not scrambling to finalize 7.4 features... Nikita > > -Original Message- > > From: Arnold Daniels > > Sent: Tuesday, July 9, 2019 9:56 AM > > T

Re: [PHP-DEV] [VOTE] Strict operators directive

2019-07-09 Thread Marco Pivetta
On Tue, Jul 9, 2019, 12:06 Christian Schneider wrote: > Am 09.07.2019 um 11:30 schrieb Marco Pivetta : > > I wasn't sure about the full implications of this, but after some > thought, > > the worst that can happen is excessive strictness, requiring to drop a > > single declaration on top of a fil

Re: [PHP-DEV] [VOTE] Strict operators directive

2019-07-09 Thread Andreas Heigl
Am 09.07.19 um 12:06 schrieb Christian Schneider: > Am 09.07.2019 um 11:30 schrieb Marco Pivetta : >> I wasn't sure about the full implications of this, but after some thought, >> the worst that can happen is excessive strictness, requiring to drop a >> single declaration on top of a file 👍 > >

Re: [PHP-DEV] [VOTE] Strict operators directive

2019-07-09 Thread Christian Schneider
Am 09.07.2019 um 11:30 schrieb Marco Pivetta : > I wasn't sure about the full implications of this, but after some thought, > the worst that can happen is excessive strictness, requiring to drop a > single declaration on top of a file 👍 When you drop the declaration on top of the file the semantic

Re: [PHP-DEV] [VOTE] Strict operators directive

2019-07-09 Thread Marco Pivetta
On Tue, Jul 9, 2019, 03:56 Arnold Daniels wrote: > Hi internals, > > I've opened voting on the strict operators directive: > https://wiki.php.net/rfc/strict_operators > > As promised, a patch and tests have been prepared. This is available on > https://github.com/php/php-src/pull/4375 > > Regards

RE: [PHP-DEV] [VOTE] Strict operators directive

2019-07-09 Thread CHU Zhaowei
Although I like this idea, I'm wondering if such a big change should go for php 8 instead of 7.4. Regards, CHU Zhaowei > -Original Message- > From: Arnold Daniels > Sent: Tuesday, July 9, 2019 9:56 AM > To: PHP Internals > Subject: [PHP-DEV] [VOTE] Strict operato

[PHP-DEV] [VOTE] Strict operators directive

2019-07-08 Thread Arnold Daniels
Hi internals, I've opened voting on the strict operators directive: https://wiki.php.net/rfc/strict_operators As promised, a patch and tests have been prepared. This is available on https://github.com/php/php-src/pull/4375 Regards, Arnold