Re: [PHP-DEV] [VOTE] Random Extension Improvement

2022-07-19 Thread Tim Düsterhus
Hi On 7/16/22 08:11, Go Kudo wrote: However, as pointed out in the PR, there are still areas that need to be improved and corrected. First of all, overloading of `getInt()` should be stopped. This is due to the fact that the signature of the `mt_rand()` function is still used, but it was pointe

Re: [PHP-DEV] [VOTE] Random Extension Improvement

2022-07-18 Thread Guilliam Xavier
> For example, what about the `$binaryString` argument name? I would recommend to either keep `$string` (conservative) or rename it to `$bytes` (consistent with the new function name) [I interpret the RFCs as the former, but the implementation is currently as the latter]. About your other mail, I

Re: [PHP-DEV] [VOTE] Random Extension Improvement

2022-07-15 Thread Go Kudo
2022年7月3日(日) 12:00 Go Kudo : > Hello internals. > > Voting began on 2022-07-02 03:00:00 (UTC) and will end on 2022-07-16 > 03:00:00 (UTC). > > https://wiki.php.net/rfc/random_extension_improvement > > Best Regards, > Go Kudo > Hi Voting was closed and all proposals were accepted. https://wiki.p

Re: [PHP-DEV] [VOTE] Random Extension Improvement

2022-07-15 Thread Go Kudo
2022年7月14日(木) 16:14 Claude Pache : > > > > Le 14 juil. 2022 à 06:32, Guilliam Xavier a > écrit : > > > > On Thursday, July 14, 2022, Go Kudo wrote: > > > >> 2022年7月13日(水) 1:10 Tim Düsterhus : > >> > >>> Hi > >>> > >>> On 7/12/22 18:04, Tim Düsterhus wrote: > I also think that both '$string'

Re: [PHP-DEV] [VOTE] Random Extension Improvement

2022-07-14 Thread Claude Pache
> Le 14 juil. 2022 à 06:32, Guilliam Xavier a écrit > : > > On Thursday, July 14, 2022, Go Kudo wrote: > >> 2022年7月13日(水) 1:10 Tim Düsterhus : >> >>> Hi >>> >>> On 7/12/22 18:04, Tim Düsterhus wrote: I also think that both '$string' and '$binary' are appropriate parameter names

Re: [PHP-DEV] [VOTE] Random Extension Improvement

2022-07-13 Thread Guilliam Xavier
On Thursday, July 14, 2022, Go Kudo wrote: > 2022年7月13日(水) 1:10 Tim Düsterhus : > >> Hi >> >> On 7/12/22 18:04, Tim Düsterhus wrote: >> > I also think that both '$string' and '$binary' are appropriate parameter >> > names in this case, so particular preference from my side. >> >> Sorry for the fo

Re: [PHP-DEV] [VOTE] Random Extension Improvement

2022-07-12 Thread Go Kudo
2022年7月8日(金) 1:44 Tim Düsterhus : > Hi > > On 7/7/22 17:52, Go Kudo wrote: > > Implementation is now proceeding. > > It includes fixes to some of the issues that were pointed out previously. > > > > https://github.com/php/php-src/pull/8094 > > > > `Randomizer::arrayPickKeys()` is currently not imp

Re: [PHP-DEV] [VOTE] Random Extension Improvement

2022-07-07 Thread Tim Düsterhus
Hi On 7/7/22 17:52, Go Kudo wrote: Implementation is now proceeding. It includes fixes to some of the issues that were pointed out previously. https://github.com/php/php-src/pull/8094 `Randomizer::arrayPickKeys()` is currently not implemented for now, since it is most likely to be rejected. (O

Re: [PHP-DEV] [VOTE] Random Extension Improvement

2022-07-07 Thread Go Kudo
2022年7月3日(日) 12:00 Go Kudo : > Hello internals. > > Voting began on 2022-07-02 03:00:00 (UTC) and will end on 2022-07-16 > 03:00:00 (UTC). > > https://wiki.php.net/rfc/random_extension_improvement > > Best Regards, > Go Kudo > Hi. Implementation is now proceeding. It includes fixes to some of th

[PHP-DEV] [VOTE] Random Extension Improvement

2022-07-02 Thread Go Kudo
Hello internals. Voting began on 2022-07-02 03:00:00 (UTC) and will end on 2022-07-16 03:00:00 (UTC). https://wiki.php.net/rfc/random_extension_improvement Best Regards, Go Kudo