Re: [PHP-DEV] [RFC] build IDs proposal

2009-01-15 Thread William A. Rowe, Jr.
Pierre Joye wrote: > > A VC6 extension is not compatible with a VC9 build (or the other way > round). It crashes randomly depending on what the extension does > (xdebug for one is really good for this test :). This is only true for specific combinations of extensions and 3p libs based on what res

Re: [PHP-DEV] [RFC] build IDs proposal

2009-01-15 Thread jvlad
> I meant "readable" :) > >> Do you mean this? >> fprintf(stderr, "%s requires Zend Engine API version %d.\n" >> "The Zend Engine API version %d which is installed, is >> outdated.\n\n", >> new_extension->name, >> First of all, php error_log may not get this message because it's thrown >

Re: [PHP-DEV] [RFC] build IDs proposal

2009-01-15 Thread Christian Seiler
Hi Pierre, > A VC6 extension is not compatible with a VC9 build (or the other way > round). It crashes randomly depending on what the extension does > (xdebug for one is really good for this test :). You wouldn't know about how VC8 fits in here? Anyway, thanks for the pointer to xdebug, I'll try

Re: [PHP-DEV] [RFC] build IDs proposal

2009-01-15 Thread Pierre Joye
On Thu, Jan 15, 2009 at 8:04 PM, Christian Seiler wrote: > Hi Pierre, > >>> Would any of the PHP Windows guys like to comment on this? >> >> I did, and the reason behind this proposal was about solving the VC* >> problem for the end users (we have to add another condition to check, >> which CRT is

Re: [PHP-DEV] [RFC] build IDs proposal

2009-01-15 Thread Pierre Joye
hi, On Thu, Jan 15, 2009 at 7:35 PM, Christian Seiler wrote: > Would any of the PHP Windows guys like to comment on this? I did, and the reason behind this proposal was about solving the VC* problem for the end users (we have to add another condition to check, which CRT is used) :) Cheers, --

Re: [PHP-DEV] [RFC] build IDs proposal

2009-01-15 Thread Christian Seiler
Hi, > I think that it would be better if we adopted more clean and scalable > solution for that. I propose having one string build ID, which would > look something like: "API20071006,NTS,Debug,VC8" and would be rquired to > match exactly in the engine and the module. This should be relatively > ea

Re: [PHP-DEV] [RFC] build IDs proposal

2009-01-15 Thread Christian Seiler
Hi Pierre, >> Would any of the PHP Windows guys like to comment on this? > > I did, and the reason behind this proposal was about solving the VC* > problem for the end users (we have to add another condition to check, > which CRT is used) :) I'm sorry for asking again, maybe I'm just plain stupi

Re: [PHP-DEV] [RFC] build IDs proposal

2009-01-15 Thread Pierre Joye
On Thu, Jan 15, 2009 at 6:31 PM, jvlad wrote: Not much work - I think I can do it in 1 day. >>> >>> Please don't forget to add human-readable error message when the IDs >>> don't >>> match. >>> Better to have different errors for different mismatching parts. >>> It's important because not all

Re: [PHP-DEV] [RFC] build IDs proposal

2009-01-15 Thread jvlad
>>> Not much work - I think I can do it in 1 day. >> >> Please don't forget to add human-readable error message when the IDs >> don't >> match. >> Better to have different errors for different mismatching parts. >> It's important because not all administrators are good with understanding >> realte

Re: [PHP-DEV] [RFC] build IDs proposal

2009-01-15 Thread Johannes Schlüter
On Wed, 2009-01-14 at 14:22 -0800, Stanislav Malyshev wrote: > I think that it would be better if we adopted more clean and scalable > solution for that. I propose having one string build ID, which would > look something like: "API20071006,NTS,Debug,VC8" and would be rquired to > match exactly i

Re: [PHP-DEV] [RFC] build IDs proposal

2009-01-15 Thread Lukas Kahwe Smith
On 14.01.2009, at 23:22, Stanislav Malyshev wrote: Hi! As many of you know, one can build PHP engine in a number of ways which are binary-incompatible - debug/no debug, thread-safe/not thread safe, etc. Also, for windows we have now anther dimension - we could build with VC6, VC8, VC9, e

Re: [PHP-DEV] [RFC] build IDs proposal

2009-01-15 Thread Pierre Joye
On Thu, Jan 15, 2009 at 5:36 AM, jvlad wrote: >>> how much work will this be? >> >> Not much work - I think I can do it in 1 day. > > Please don't forget to add human-readable error message when the IDs don't > match. > Better to have different errors for different mismatching parts. > It's import

Re: [PHP-DEV] [RFC] build IDs proposal

2009-01-14 Thread jvlad
>> how much work will this be? > > Not much work - I think I can do it in 1 day. Please don't forget to add human-readable error message when the IDs don't match. Better to have different errors for different mismatching parts. It's important because not all administrators are good with understan

Re: [PHP-DEV] [RFC] build IDs proposal

2009-01-14 Thread Pierre Joye
On Thu, Jan 15, 2009 at 12:06 AM, Lukas Kahwe Smith wrote: > > On 14.01.2009, at 23:22, Stanislav Malyshev wrote: > how much work will this be? Very little work, see zend_extension.c line 60, we only have to replace this test and update definition for the default header (zend_extension struct us

Re: [PHP-DEV] [RFC] build IDs proposal

2009-01-14 Thread Stanislav Malyshev
Hi! how much work will this be? Not much work - I think I can do it in 1 day. what kind of risk will it bring? not much I guess as it will influence only how extensions are loaded - once extension loads, pretty much the deed is done and that code influences nothing. -- Stanislav Malyshe

Re: [PHP-DEV] [RFC] build IDs proposal

2009-01-14 Thread Lukas Kahwe Smith
On 14.01.2009, at 23:22, Stanislav Malyshev wrote: Hi! As many of you know, one can build PHP engine in a number of ways which are binary-incompatible - debug/no debug, thread-safe/not thread safe, etc. Also, for windows we have now anther dimension - we could build with VC6, VC8, VC9, e

Re: [PHP-DEV] [RFC] build IDs proposal

2009-01-14 Thread Pierre Joye
On Wed, Jan 14, 2009 at 11:22 PM, Stanislav Malyshev wrote: > Hi! > > As many of you know, one can build PHP engine in a number of ways which are > binary-incompatible - debug/no debug, thread-safe/not thread safe, etc. > Also, for windows we have now anther dimension - we could build with VC6, >

[PHP-DEV] [RFC] build IDs proposal

2009-01-14 Thread Stanislav Malyshev
Hi! As many of you know, one can build PHP engine in a number of ways which are binary-incompatible - debug/no debug, thread-safe/not thread safe, etc. Also, for windows we have now anther dimension - we could build with VC6, VC8, VC9, etc. Loading modules built with another, binary incompati