Re: [PHP-DEV] [RFC] Warn about invalid strings in arithmetic (moving backtodiscussion)

2016-02-05 Thread Andrea Faulds
Hi Mike, Michael Wallner wrote: To be honest, I had not even memorised intval() supports a base, but that we have base_convert(). I’d opt for dropping base convert support from intval(), but that’s obviously not possible, because PHP-7.1 is the target for this RFC. Yeah, it's easy to forge

Re: [PHP-DEV] [RFC] Warn about invalid strings in arithmetic (moving backtodiscussion)

2016-02-05 Thread Michael Wallner
> On 05 02 2016, at 11:49, Andrea Faulds wrote: > > Hi again, > > Andrea Faulds wrote: >> There is one unresolved issue with the current patch that the RFC >> doesn't address, so I'll ask about it here. >> >> As part of supporting exponent notation in all remaining integer >> operations (casts

[PHP-DEV] [RFC] Warn about invalid strings in arithmetic (moving back to discussion)

2016-01-26 Thread Andrea Faulds
Good evening, I had opened the vote for this RFC, but then I was reminded by a discussion in the pull request about a particular unresolved problem I had forgotten about. In order to deal with that issue, I have cancelled the vote and expanded the RFC (both in length and scope) to deal with

Re: [PHP-DEV] [RFC] Warn about invalid strings in arithmetic

2016-01-08 Thread Andrea Faulds
Hi François, François Laupretre wrote: I would suggest we still accept leading and trailing blanks without E_NOTICE. That's easy to implement (leading blanks are already accepted and adding non-blank trailing char detection is trivial) and would greatly reduce BC breaks. Leading whitespace is

Re: [PHP-DEV] [RFC] Warn about invalid strings in arithmetic

2016-01-07 Thread François Laupretre
Hi Andrea, Le 08/01/2016 01:03, Andrea Faulds a écrit : Hi everyone, I'm proposing a new RFC to make it easier to spot errors when using PHP's arithmetic operators: https://wiki.php.net/rfc/invalid_strings_in_arithmetic Please read it and tell me your thoughts. Thanks! I would suggest we s

[PHP-DEV] [RFC] Warn about invalid strings in arithmetic

2016-01-07 Thread Andrea Faulds
Hi everyone, I'm proposing a new RFC to make it easier to spot errors when using PHP's arithmetic operators: https://wiki.php.net/rfc/invalid_strings_in_arithmetic Please read it and tell me your thoughts. Thanks! -- Andrea Faulds https://ajf.me/ -- PHP Internals - PHP Runtime Development M