Re: [PHP-DEV] [RFC] Under Discussion: Default User-Agent for cURL

2021-08-03 Thread Hans Henrik Bergan
> > or doing nothing at all. > Sounds good to me. On Tue, 3 Aug 2021 at 16:47, Sara Golemon wrote: > On Tue, Aug 3, 2021 at 4:45 AM Hans Henrik Bergan > wrote: > >> fwiw i think no self-respecting codebase is depending on an ini-setting >> being correct for the ua in cases where the ua is actua

Re: [PHP-DEV] [RFC] Under Discussion: Default User-Agent for cURL

2021-08-03 Thread Sara Golemon
On Tue, Aug 3, 2021 at 4:45 AM Hans Henrik Bergan wrote: > fwiw i think no self-respecting codebase is depending on an ini-setting > being correct for the ua in cases where the ua is actually important, so > the breakage should be minimal. > > In my mind, this is either an argument in favor of ei

Re: [PHP-DEV] [RFC] Under Discussion: Default User-Agent for cURL

2021-08-03 Thread Hans Henrik Bergan
fwiw i think no self-respecting codebase is depending on an ini-setting being correct for the ua in cases where the ua is actually important, so the breakage should be minimal. On Sun, 27 Jun 2021 at 09:25, Aleksander Machniak wrote: > On 27.06.2021 08:48, Michael Maroszek wrote: > > That's what

Re: [PHP-DEV] [RFC] Under Discussion: Default User-Agent for cURL

2021-07-08 Thread Michael Maroszek
Hi Dan, that sounds reasonable. I have also updated the target to 8.2 and will wait a big more to give everyone extra time. Am Mi., 7. Juli 2021 um 18:13 Uhr schrieb Dan Ackroyd < dan...@basereality.com>: > On Tue, 6 Jul 2021 at 15:58, Michael Maroszek wrote: > > > > Dear internals, > > > > I d

Re: [PHP-DEV] [RFC] Under Discussion: Default User-Agent for cURL

2021-07-07 Thread Dan Ackroyd
On Tue, 6 Jul 2021 at 15:58, Michael Maroszek wrote: > > Dear internals, > > I didn't receive any more feedback on this RFC, therefore I would like to > start voting next week on the RFC as is. fyi, I think you'll need to update the 'Proposed PHP Version' to 8.2. Ben Ramsey wrote on 22 Jun 2021

Re: [PHP-DEV] [RFC] Under Discussion: Default User-Agent for cURL

2021-07-06 Thread Michael Maroszek
Dear internals, I didn't receive any more feedback on this RFC, therefore I would like to start voting next week on the RFC as is. Rationale: - I would like to stick with a distinct curl.user_agent ini option to avoid the BC break. - Also using PHP_INI_ALL as the options visibility is matching th

Re: [PHP-DEV] [RFC] Under Discussion: Default User-Agent for cURL

2021-06-29 Thread Michael Maroszek
Hi! Would anyone else be in favor of reusing the user_agent setting for cURL despite the BC break? At the moment all possibilities (user_agent, curl.user_agent (PHP_INI_ALL), curl.user_agent (PHP_INI_SYSTEM)) seem to have negative votes attached. I am unsure if it makes sense to go forward with

Re: [PHP-DEV] [RFC] Under Discussion: Default User-Agent for cURL

2021-06-27 Thread Aleksander Machniak
On 27.06.2021 08:48, Michael Maroszek wrote: > That's what I also thought when making the PR and therefore I initially > went with PHP_INI_ALL. > > But Tyson made a good point that the curl.cainfo is PHP_INI_SYSTEM and we > might want to be consistent about modes inside an extension. Another opti

Re: [PHP-DEV] [RFC] Under Discussion: Default User-Agent for cURL

2021-06-26 Thread Michael Maroszek
Hi Aleksander, That's what I also thought when making the PR and therefore I initially went with PHP_INI_ALL. But Tyson made a good point that the curl.cainfo is PHP_INI_SYSTEM and we might want to be consistent about modes inside an extension. I'd love to hear some more opinions on which direct

Re: [PHP-DEV] [RFC] Under Discussion: Default User-Agent for cURL

2021-06-26 Thread Aleksander Machniak
On 25.06.2021 16:33, Michael Maroszek wrote: > > Please have a look at the full RFC: https://wiki.php.net/rfc/curl_user_agent > > There is one open issue which Tyson raised to find the correct mode for the > ini option. Either PHP_INI_ALL or PHP_INI_SYSTEM is currently being > discussed. See here

[PHP-DEV] [RFC] Under Discussion: Default User-Agent for cURL

2021-06-25 Thread Michael Maroszek
Dear internals, I would like to propose an RFC to add a new php.ini option called curl.user_agent which allows setting a default User-Agent for all cURL requests. This option is the equivalent to user_agent for stream based functions (like file_get_contents). The proposal is quite simple and has n