Re: [PHP-DEV] [RFC] Reproducible Builds Support

2017-12-24 Thread Jelle van der Waa
On 12/15/17 at 11:54am, Sebastian Bergmann wrote: > Am 15.12.2017 um 11:13 schrieb Jordi Boggiano: > > I guess an alternative fix would be for someone to actually fix the Phar > > extension so addFromString has a filemtime parameter you can pass the > > desired mtime to. I have not checked whether

Re: [PHP-DEV] [RFC] Reproducible Builds Support

2017-12-15 Thread Sebastian Bergmann
Am 15.12.2017 um 11:13 schrieb Jordi Boggiano: > I guess an alternative fix would be for someone to actually fix the Phar > extension so addFromString has a filemtime parameter you can pass the > desired mtime to. I have not checked whether addFile suffers from the same > issue or not, but possibly

Re: [PHP-DEV] [RFC] Reproducible Builds Support

2017-12-15 Thread Jordi Boggiano
On 2017-12-14 10:02 AM, Jelle van der Waa wrote: The last issue is phar.phar being non-reproducible of which I am not sure what the issue would be. I'm not sure how the binary data in the phar.phar is generated. Phars are like `tars` that are also valid PHP files. This means there are probably

Re: [PHP-DEV] [RFC] Reproducible Builds Support

2017-12-14 Thread Jelle van der Waa
On 12/12/17 at 02:12pm, Levi Morrison wrote: > On Mon, Dec 11, 2017 at 2:11 PM, Jelle van der Waa wrote: > > Hi all, > > > > Debian, Arch Linux and other distro's are trying to get full > > reproducible builds. There are some issues in PHP's codebase which makes > > builds unreproducible. Reprodic

Re: [PHP-DEV] [RFC] Reproducible Builds Support

2017-12-12 Thread Stanislav Malyshev
Hi! >> I think the best solution here would be to have another variable to >> override this. > > The issue with this approach would be that every distribution has to set > this variable. I know it's the same with SOURCE_DATE_EPOCH, but that is > well established. All distros that want reproducib

Re: [PHP-DEV] [RFC] Reproducible Builds Support

2017-12-12 Thread Levi Morrison
On Mon, Dec 11, 2017 at 2:11 PM, Jelle van der Waa wrote: > Hi all, > > Debian, Arch Linux and other distro's are trying to get full > reproducible builds. There are some issues in PHP's codebase which makes > builds unreproducible. Reprodicuble builds are currently reproduced in > Arch Linux by b

Re: [PHP-DEV] [RFC] Reproducible Builds Support

2017-12-12 Thread Jelle van der Waa
On 12/11/17 at 11:33pm, Stanislav Malyshev wrote: > Hi! > > > Once issue is the PHP_BUILD_DATE, which makes the build > > non-reproducible. I've made a PR which uses SOURCE_DATE_EPOCH which is > > set in the reprodiculbe build env. This should keep the current > > functionality intact, while addin

Re: [PHP-DEV] [RFC] Reproducible Builds Support

2017-12-11 Thread Stanislav Malyshev
Hi! > Once issue is the PHP_BUILD_DATE, which makes the build > non-reproducible. I've made a PR which uses SOURCE_DATE_EPOCH which is > set in the reprodiculbe build env. This should keep the current > functionality intact, while adding support for reproducible builds. [2] > [3] SOURCE_DATE_EPOC

[PHP-DEV] [RFC] Reproducible Builds Support

2017-12-11 Thread Jelle van der Waa
Hi all, Debian, Arch Linux and other distro's are trying to get full reproducible builds. There are some issues in PHP's codebase which makes builds unreproducible. Reprodicuble builds are currently reproduced in Arch Linux by building PHP twice, and in two different env's, varying hostname, syste