Re: [PHP-DEV] [RFC] Preserve Fractional Part in JSON encode

2015-01-10 Thread Andrea Faulds
> On 11 Jan 2015, at 02:26, Juan Basso wrote: > > I renamed the constant name on the RFC. Can I open the voting? Hey Juan, It’s been long enough, and the constant name is a minor issue. Go for it. :) -- Andrea Faulds http://ajf.me/ -- PHP Internals - PHP Runtime Development Mailing List

Re: [PHP-DEV] [RFC] Preserve Fractional Part in JSON encode

2015-01-10 Thread Juan Basso
I renamed the constant name on the RFC. Can I open the voting? On Wed, Jan 7, 2015 at 7:14 PM, Juan Basso wrote: > I really like the new name and the consistence with the rest of php. If no > one else has a complain about it I will update the RFC and open for voting, > right? > > Juan Basso > On

Re: [PHP-DEV] [RFC] Preserve Fractional Part in JSON encode

2015-01-07 Thread Juan Basso
I really like the new name and the consistence with the rest of php. If no one else has a complain about it I will update the RFC and open for voting, right? Juan Basso On Jan 5, 2015 7:31 AM, "Ferenc Kovacs" wrote: > > > On Mon, Jan 5, 2015 at 5:18 AM, Juan Basso wrote: > >> Hi, >> >> Everyone

Re: [PHP-DEV] [RFC] Preserve Fractional Part in JSON encode

2015-01-05 Thread Ferenc Kovacs
On Mon, Jan 5, 2015 at 5:18 AM, Juan Basso wrote: > Hi, > > Everyone has any concern on the constant name as Andrea mentioned? Should > we keep or rename it? If this name is fine and there is no other concerns > probably in 3 days (when completes 2 weeks) this RFC can be moved to > voting, right?

Re: [PHP-DEV] [RFC] Preserve Fractional Part in JSON encode

2015-01-04 Thread Juan Basso
Hi, Everyone has any concern on the constant name as Andrea mentioned? Should we keep or rename it? If this name is fine and there is no other concerns probably in 3 days (when completes 2 weeks) this RFC can be moved to voting, right? Thanks, Juan Basso On Thu, Dec 25, 2014 at 9:17 PM, Juan Ba

Re: [PHP-DEV] [RFC] Preserve Fractional Part in JSON encode

2014-12-25 Thread Juan Basso
Andrea, I am not a specialist in float numbers, but I think integral float numbers have a fractional part with value 0. JSON_FLOAT_ADD_POINT_ZERO can be confuse for regular floats with non-zero as fractional part. Seems you are going to add a point zero in a regular float with point something. A

Re: [PHP-DEV] [RFC] Preserve Fractional Part in JSON encode

2014-12-25 Thread Andrea Faulds
> On 25 Dec 2014, at 19:32, Juan Basso wrote: > > The RFC can be found here: > https://wiki.php.net/rfc/json_preserve_fractional_part Hey Juan, A further thought: is “Preserve Fractional Part” the best name? Integral floats like float(12) don’t have any fractional part, and besides, the name

Re: [PHP-DEV] [RFC] Preserve Fractional Part in JSON encode

2014-12-25 Thread Juan Basso
Exactly. The idea of this RFC is just to add as a new option and not enabled by default. The idea to enable it by default was discussed before and I just added as future scope since it is not an easy decision, especially because the backward compatibility. The main goal is to have the option to ch

Re: [PHP-DEV] [RFC] Preserve Fractional Part in JSON encode

2014-12-25 Thread Stanislav Malyshev
Hi! > Good evening and merry christmas, > > After some discussion in a separated thread I created the RFC to discuss > about the implementation of another json_encode option. > > The RFC can be found here: > https://wiki.php.net/rfc/json_preserve_fractional_part Completely makes sense for me as

Re: [PHP-DEV] [RFC] Preserve Fractional Part in JSON encode

2014-12-25 Thread Ferenc Kovacs
On Thu, Dec 25, 2014 at 9:05 PM, Andrea Faulds wrote: > > > On 25 Dec 2014, at 19:32, Juan Basso wrote: > > > > Good evening and merry christmas, > > > > After some discussion in a separated thread I created the RFC to discuss > > about the implementation of another json_encode option. > > > > T

Re: [PHP-DEV] [RFC] Preserve Fractional Part in JSON encode

2014-12-25 Thread Andrea Faulds
> On 25 Dec 2014, at 19:32, Juan Basso wrote: > > Good evening and merry christmas, > > After some discussion in a separated thread I created the RFC to discuss > about the implementation of another json_encode option. > > The RFC can be found here: > https://wiki.php.net/rfc/json_preserve_fra

[PHP-DEV] [RFC] Preserve Fractional Part in JSON encode

2014-12-25 Thread Juan Basso
Good evening and merry christmas, After some discussion in a separated thread I created the RFC to discuss about the implementation of another json_encode option. The RFC can be found here: https://wiki.php.net/rfc/json_preserve_fractional_part Juan Basso