RE: [PHP-DEV] [RFC] Performance improvements

2010-04-29 Thread Andi Gutmans
Original Message- > From: Benjamin Eberlei [mailto:kont...@beberlei.de] > Sent: Thursday, April 29, 2010 3:08 AM > To: internals@lists.php.net; r.borsc...@gmx.net > Subject: Re: [PHP-DEV] [RFC] Performance improvements > > > We wanted to share some of our insights on the pe

Re: [PHP-DEV] [RFC] Performance improvements

2010-04-29 Thread Benjamin Eberlei
We wanted to share some of our insights on the performance patches. Roman did some tests on the Doctrine 2 performance testsuite to check the benefits of the performance improvements and they are pretty impressive (Thanks Dimitry!). Our performance testsuite containts pretty intense and h

Re: [PHP-DEV] [RFC] Performance improvements

2010-04-20 Thread Dmitry Stogov
Jordi Boggiano wrote: On 20.04.2010 12:41, Derick Rethans wrote: You're writing that the ZEND_CATCH opcode has to be used with a constant class name, so how would "catch ( self $e )" be represented in op-codes now? I dropped such possibility. Does someone use it? For me it looks useless. If i

Re: [PHP-DEV] [RFC] Performance improvements

2010-04-20 Thread Jordi Boggiano
On 20.04.2010 12:41, Derick Rethans wrote: >>> You're writing that the ZEND_CATCH opcode has to be used with a constant >>> class name, so how would "catch ( self $e )" be represented in op-codes now? >> >> I dropped such possibility. Does someone use it? >> For me it looks useless. If it's really

Re: [PHP-DEV] [RFC] Performance improvements

2010-04-20 Thread Derick Rethans
On Tue, 20 Apr 2010, Dmitry Stogov wrote: > Derick Rethans wrote: > > On Tue, 13 Apr 2010, Dmitry Stogov wrote: > > > > > I've published all the patches, their description and performance > > > evaluation > > > at http://wiki.php.net/rfc/performanceimprovements > > > > I've a few questions and c

Re: [PHP-DEV] [RFC] Performance improvements

2010-04-20 Thread Dmitry Stogov
Hi Derick, Thank you for review. Derick Rethans wrote: On Tue, 13 Apr 2010, Dmitry Stogov wrote: I've published all the patches, their description and performance evaluation at http://wiki.php.net/rfc/performanceimprovements I've a few questions and comments: http://wiki.php.net/rfc/perfor

Re: [PHP-DEV] [RFC] Performance improvements

2010-04-20 Thread Sebastian Bergmann
Am 20.04.2010 09:21, schrieb Derick Rethans: > You're writing that the ZEND_CATCH opcode has to be used with a constant > class name, so how would "catch ( self $e )" be represented in op-codes > now? Is self not replaced with the class name at compile time? And why would you write such code?

Re: [PHP-DEV] [RFC] Performance improvements

2010-04-20 Thread Derick Rethans
On Tue, 13 Apr 2010, Dmitry Stogov wrote: > I've published all the patches, their description and performance evaluation > at http://wiki.php.net/rfc/performanceimprovements I've a few questions and comments: http://wiki.php.net/rfc/performanceimprovements#zend_engine_vm_tuning You're writing t

Re: [PHP-DEV] [RFC] Performance improvements

2010-04-20 Thread Dmitry Stogov
Hi Christopher, Christopher Jones wrote: Dmitry Stogov wrote: > Hi, > > I've added the corresponding patch for APC, so anyone is able to verify > the performance difference. > > http://wiki.php.net/rfc/performanceimprovements Dmitry, What do you think caused the "fw" difference in abso

Re: [PHP-DEV] [RFC] Performance improvements

2010-04-19 Thread Christopher Jones
Dmitry Stogov wrote: > Hi, > > I've added the corresponding patch for APC, so anyone is able to verify > the performance difference. > > http://wiki.php.net/rfc/performanceimprovements Dmitry, What do you think caused the "fw" difference in absolute figures between the APC and Zend Optimizer+

Re: [PHP-DEV] [RFC] Performance improvements

2010-04-19 Thread Dmitry Stogov
Kalle Sommer Nielsen wrote: Hi Dmitry 2010/4/19 Dmitry Stogov : Hi, I've added the corresponding patch for APC, so anyone is able to verify the performance difference. http://wiki.php.net/rfc/performanceimprovements Thanks. Dmitry. Dmitry Stogov wrote: In the patched config.w32, you wro

Re: [PHP-DEV] [RFC] Performance improvements

2010-04-19 Thread Kalle Sommer Nielsen
Hi Dmitry 2010/4/19 Dmitry Stogov : > Hi, > > I've added the corresponding patch for APC, so anyone is able to verify the > performance difference. > > http://wiki.php.net/rfc/performanceimprovements > > Thanks. Dmitry. > > Dmitry Stogov wrote: In the patched config.w32, you wrote zend_string.c,

Re: [PHP-DEV] [RFC] Performance improvements

2010-04-19 Thread Dmitry Stogov
Hi, I've added the corresponding patch for APC, so anyone is able to verify the performance difference. http://wiki.php.net/rfc/performanceimprovements Thanks. Dmitry. Dmitry Stogov wrote: Hi, I've published all the patches, their description and performance evaluation at http://wiki.php.

Re: [PHP-DEV] [RFC] Performance improvements

2010-04-13 Thread Dmitry Stogov
Hi Kalle, Kalle Sommer Nielsen wrote: Hi 2010/4/13 Dmitry Stogov : Hi, I've published all the patches, their description and performance evaluation at http://wiki.php.net/rfc/performanceimprovements The only thing I notice while browsing the patches was that you need to add the zend_string.

Re: [PHP-DEV] [RFC] Performance improvements

2010-04-13 Thread Dmitry Stogov
com] Sent: 13 April 2010 14:53 To: internals@lists.php.net Subject: [PHP-DEV] [RFC] Performance improvements Hi, I've published all the patches, their description and performance evaluation at http://wiki.php.net/rfc/performanceimprovements In two words the patches give 0-20% improvemen

Re: [PHP-DEV] [RFC] Performance improvements

2010-04-13 Thread Dmitry Stogov
Hi Richard, Richard Quadling wrote: On 13 April 2010 14:53, Dmitry Stogov wrote: Hi, I've published all the patches, their description and performance evaluation at http://wiki.php.net/rfc/performanceimprovements In two words the patches give 0-20% improvement even on real-life applications.

Re: [PHP-DEV] [RFC] Performance improvements

2010-04-13 Thread Kalle Sommer Nielsen
Hi 2010/4/13 Dmitry Stogov : > Hi, > > I've published all the patches, their description and performance evaluation > at http://wiki.php.net/rfc/performanceimprovements The only thing I notice while browsing the patches was that you need to add the zend_string.c and other new files to win32/build

RE: [PHP-DEV] [RFC] Performance improvements

2010-04-13 Thread Jared Williams
igbinary could be patched to take advantage of string interning? -Jared > -Original Message- > From: Dmitry Stogov [mailto:dmi...@zend.com] > Sent: 13 April 2010 14:53 > To: internals@lists.php.net > Subject: [PHP-DEV] [RFC] Performance improvements > > Hi, >

[PHP-DEV] [RFC] Performance improvements

2010-04-13 Thread Dmitry Stogov
Hi, I've published all the patches, their description and performance evaluation at http://wiki.php.net/rfc/performanceimprovements In two words the patches give 0-20% improvement even on real-life applications. I'm going to commit them into trunk in a week in case of no objections. Of cou