Re: [PHP-DEV] [RFC] Kill proprietary CSV escaping mechanism

2018-12-02 Thread Stanislav Malyshev
Hi! > implementation. Therefore, I suggest to only add support for an empty > $escape parameter (PR #3515), Sounds good. -- Stas Malyshev smalys...@gmail.com -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-DEV] [RFC] Kill proprietary CSV escaping mechanism

2018-12-02 Thread Christoph M. Becker
On 30.09.2018 at 22:17, Stanislav Malyshev wrote: >> If we cannot eventually get rid of the escaping for CSV reading (note >> that I proposed to keep the possibility to use it until PHP *9*), I >> don't think that we should remove it for CSV writing either, since that >> would make SplFileObject::

[PHP-DEV] [RFC] Kill proprietary CSV escaping mechanism

2018-10-01 Thread ignace nyamagana butera
As a library maintainer I agree with Stanislav Malyshev . I'm currently working on a polyfill in League\Csv to enable usage of the empty string with the escape character. While providing such feature is straightforward for the insertion part, doing the same for the reading part in quite complex be

Re: [PHP-DEV] [RFC] Kill proprietary CSV escaping mechanism

2018-09-30 Thread Stanislav Malyshev
Hi! > If we cannot eventually get rid of the escaping for CSV reading (note > that I proposed to keep the possibility to use it until PHP *9*), I > don't think that we should remove it for CSV writing either, since that > would make SplFileObject::setCsvControl() and ::getCsvControl() pretty > muc

Re: [PHP-DEV] [RFC] Kill proprietary CSV escaping mechanism

2018-09-30 Thread Christoph M. Becker
On 30.09.2018 at 12:42, Nikita Popov wrote: > On Thu, Sep 27, 2018 at 12:29 PM Christoph M. Becker > wrote: > >> I hereby put the “Kill proprietary CSV escaping mechanism” under >> discussion: >> >> >> >> Any comments are welcome! > > Could you pleas

Re: [PHP-DEV] [RFC] Kill proprietary CSV escaping mechanism

2018-09-30 Thread Nikita Popov
On Thu, Sep 27, 2018 at 12:29 PM Christoph M. Becker wrote: > Hi! > > I hereby put the “Kill proprietary CSV escaping mechanism” under > discussion: > > > > Any comments are welcome! > Could you please add a description of how the escaping mechanism c

Re: [PHP-DEV] [RFC] Kill proprietary CSV escaping mechanism

2018-09-30 Thread Christoph M. Becker
On 30.09.2018 at 06:06, Pierre Joye wrote: > On Fri, Sep 28, 2018, 2:00 PM Stanislav Malyshev > wrote: > >>> I hereby put the “Kill proprietary CSV escaping mechanism” under >> discussion: >>> >>> >> >> For fputcsv (and generally writing) this is prob

Re: [PHP-DEV] [RFC] Kill proprietary CSV escaping mechanism

2018-09-29 Thread Pierre Joye
Hi Stas On Fri, Sep 28, 2018, 2:00 PM Stanislav Malyshev wrote: > Hi! > > > I hereby put the “Kill proprietary CSV escaping mechanism” under > discussion: > > > > > > For fputcsv (and generally writing) this is probably OK. I am much more > concerned

Re: [PHP-DEV] [RFC] Kill proprietary CSV escaping mechanism

2018-09-28 Thread Stanislav Malyshev
Hi! > I hereby put the “Kill proprietary CSV escaping mechanism” under discussion: > > For fputcsv (and generally writing) this is probably OK. I am much more concerned about reading - this may make files generated by PHP be unreadable by php. And som

Re: [PHP-DEV] [RFC] Kill proprietary CSV escaping mechanism

2018-09-27 Thread Theodore Brown
On Thursday, September 27, 2018 5:29 AM Christoph M. Becker wrote: > I hereby put the “Kill proprietary CSV escaping mechanism” under discussion: > > > > Any comments are welcome! Huge +1 from me! This would remove the need for a lot of nasty hacks a

[PHP-DEV] [RFC] Kill proprietary CSV escaping mechanism

2018-09-27 Thread Christoph M. Becker
Hi! I hereby put the “Kill proprietary CSV escaping mechanism” under discussion: Any comments are welcome! -- Christoph M. Becker -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php