Re: [PHP-DEV] [RFC] Decoding HTML and the Ambiguous Ampersand

2024-08-25 Thread Dennis Snell
> On Aug 25, 2024, at 4:17 PM, Máté Kocsis wrote: > > Hi Christoph, Dennis, > >> Well, I don't think it would be a big deal to move the bundled lexbor to >> somewhere where it is always available. I mean, so far it's only used >> by ext/dom so it's bundled there, but if other parts of the php-

Re: [PHP-DEV] [RFC] Decoding HTML and the Ambiguous Ampersand

2024-08-25 Thread Máté Kocsis
Hi Christoph, Dennis, Well, I don't think it would be a big deal to move the bundled lexbor to > somewhere where it is always available. I mean, so far it's only used > by ext/dom so it's bundled there, but if other parts of the php-src code > base would use it, we could put it elsewhere. > Exac

Re: [PHP-DEV] [RFC] Decoding HTML and the Ambiguous Ampersand

2024-08-25 Thread Dennis Snell
> On Aug 25, 2024, at 3:15 AM, Jakob Givoni wrote: > > > On Sat, Aug 24, 2024 at 10:31 PM Dennis Snell > wrote: >> On Aug 24, 2024, at 2:56 PM, Jakob Givoni > > wrote: >>> >>> Hi Dennis, >>> >>> Overall it sounds like a reasonable R

Re: [PHP-DEV] [RFC] Decoding HTML and the Ambiguous Ampersand

2024-08-25 Thread Jakob Givoni
On Sat, Aug 24, 2024 at 10:31 PM Dennis Snell wrote: > On Aug 24, 2024, at 2:56 PM, Jakob Givoni wrote: > > > Hi Dennis, > > Overall it sounds like a reasonable RFC. > > > Dennis: > > > > > Niels: > > > > > > I'm not so sure that the name "decode_html" is self-descriptive > enough, it sounds ver

Re: [PHP-DEV] [RFC] Decoding HTML and the Ambiguous Ampersand

2024-08-24 Thread Dennis Snell
> On Aug 24, 2024, at 7:47 AM, Christoph M. Becker wrote: > > On 23.08.2024 at 01:02, Dennis Snell wrote: > >>> If we could have a single implementation, that would be great. I do >>> understand of course your concern that DOM is not a required extension, and >>> therefore basing the intern

Re: [PHP-DEV] [RFC] Decoding HTML and the Ambiguous Ampersand

2024-08-24 Thread Dennis Snell
On Aug 24, 2024, at 2:56 PM, Jakob Givoni wrote: > > Hi Dennis, > > Overall it sounds like a reasonable RFC. > > > Dennis: > > > > > Niels: > > > > > > I'm not so sure that the name "decode_html" is self-descriptive enough, > > > it sounds very generic. > > > > The name is not very important

Re: [PHP-DEV] [RFC] Decoding HTML and the Ambiguous Ampersand

2024-08-24 Thread Jakob Givoni
Hi Dennis, Overall it sounds like a reasonable RFC. > Dennis: > > > Niels: > > > > I'm not so sure that the name "decode_html" is self-descriptive enough, it sounds very generic. > > The name is not very important to me. For the sake of history, the reason I have chosen “decode HTML” is because,

Re: [PHP-DEV] [RFC] Decoding HTML and the Ambiguous Ampersand

2024-08-24 Thread Christoph M. Becker
On 23.08.2024 at 01:02, Dennis Snell wrote: >> If we could have a single implementation, that would be great. I do >> understand of course your concern that DOM is not a required extension, and >> therefore basing the internals on Lexbor makes it tied to the DOM extension >> which may not be av

Re: [PHP-DEV] [RFC] Decoding HTML and the Ambiguous Ampersand

2024-08-22 Thread Bruce Weirdan
On Fri, Aug 23, 2024 at 1:03 AM Dennis Snell wrote: > Just for reference, since I’ve looked before and not found it. Can > someone indicate where to find the PHP function documentation? There are a > number of updates I would love to propose but I don’t know where to find > the content that appe

Re: [PHP-DEV] [RFC] Decoding HTML and the Ambiguous Ampersand

2024-08-22 Thread Dennis Snell
> On Aug 22, 2024, at 5:01 PM, Niels Dossche wrote: > > On 20/08/2024 00:45, Dennis Snell wrote: >> >>> On Jul 9, 2024, at 4:55 PM, Dennis Snell wrote: >>> >>> Greetings all, >>> >>> The `html_entity_decode( … ENT_HTML5 … )` function has a number of issues >>> that I’d like to correct. >>>