Re: [PHP-DEV] [RFC] Allow trailing comma in parameter lists

This would make PHP more consistent. Please add this! On Mon, Mar 30, 2020, at 12:32 PM, Guilliam Xavier wrote: > On Sun, Mar 29, 2020 at 11:31 PM Jakob Givoni wrote: > > > > Hi Rowan, > > > > On Sat, Mar 28, 2020 at 4:01 PM Rowan Tommins > > wrote: > > > > > > While I'd personally be fine with

Re: [PHP-DEV] [RFC] Allow trailing comma in parameter lists

On Sun, Mar 29, 2020 at 11:31 PM Jakob Givoni wrote: > > Hi Rowan, > > On Sat, Mar 28, 2020 at 4:01 PM Rowan Tommins wrote: > > > > While I'd personally be fine with this change, I think we should > > understand why the previous proposal failed rather than just hoping the > > vote goes differentl

Re: [PHP-DEV] [RFC] Allow trailing comma in parameter lists

Hi Rowan, On Sat, Mar 28, 2020 at 4:01 PM Rowan Tommins wrote: > > While I'd personally be fine with this change, I think we should > understand why the previous proposal failed rather than just hoping the > vote goes differently this time. I think you have a good point here. I've only been arou

Re: [PHP-DEV] [RFC] Allow trailing comma in parameter lists

On 26/03/2020 18:52, Nikita Popov wrote: Hi internals, This has been declined in the past, but I just keep making this mistake, and believe it deserves reconsideration... https://wiki.php.net/rfc/trailing_comma_in_parameter_list Nikita Hi Nikita, While I'd personally be fine with this chan

Re: [PHP-DEV] [RFC] Allow trailing comma in parameter lists

> > Hi internals, > > This has been declined in the past, but I just keep making this mistake, > and believe it deserves reconsideration... > > https://wiki.php.net/rfc/trailing_comma_in_parameter_list > > Nikita I have no idea why we failed to approve trailing comma over lists in general, but thi

Re: [PHP-DEV] [RFC] Allow trailing comma in parameter lists

On 27.03.2020 at 14:58, tyson andre wrote: > I'd just like to add that > https://wiki.php.net/rfc/trailing_comma_in_parameter_list seems useful, > especially now that PSR-12 is approved and > https://www.php-fig.org/psr/psr-12/#45-method-and-function-arguments > recommends that > "When the argu

Re: [PHP-DEV] [RFC] Allow trailing comma in parameter lists

Hi internals, I'd just like to add that https://wiki.php.net/rfc/trailing_comma_in_parameter_list seems useful, especially now that PSR-12 is approved and https://www.php-fig.org/psr/psr-12/#45-method-and-function-arguments recommends that "When the argument list is split across multiple lines,

Re: [PHP-DEV] [RFC] Allow trailing comma in parameter lists

> On Mar 26, 2020, at 13:52, Nikita Popov wrote: > > Hi internals, > > This has been declined in the past, but I just keep making this mistake, > and believe it deserves reconsideration... > > https://wiki.php.net/rfc/trailing_comma_in_parameter_list > > Nikita Yes, please Cheers, Ben sig

Re: [PHP-DEV] [RFC] Allow trailing comma in parameter lists

On Thu, Mar 26, 2020, at 1:52 PM, Nikita Popov wrote: > Hi internals, > > This has been declined in the past, but I just keep making this mistake, > and believe it deserves reconsideration... > > https://wiki.php.net/rfc/trailing_comma_in_parameter_list > > Nikita Endorse. I don't think there'

Re: [PHP-DEV] [RFC] Allow trailing comma in parameter lists

On Thu, Mar 26, 2020 at 7:52 PM Nikita Popov wrote: > Hi internals, > > This has been declined in the past, but I just keep making this mistake, > and believe it deserves reconsideration... > > https://wiki.php.net/rfc/trailing_comma_in_parameter_list > > Nikita > This would be a great addition,

[PHP-DEV] [RFC] Allow trailing comma in parameter lists

Hi internals, This has been declined in the past, but I just keep making this mistake, and believe it deserves reconsideration... https://wiki.php.net/rfc/trailing_comma_in_parameter_list Nikita