Re: [PHP-DEV] [RFC] Add hash_pbkdf2 function

2012-06-29 Thread Anthony Ferrara
Pierre, > Quick reminder, it will be -1 from here if it targets 5.4, for all the > reasons I have been repeatedly explaining. I've updated the RFC to indicate such (that it's only targeting master (5.5)). Thanks, Anthony -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe,

Re: [PHP-DEV] [RFC] Add hash_pbkdf2 function

2012-06-29 Thread Pierre Joye
hi, On Fri, Jun 29, 2012 at 4:19 PM, Anthony Ferrara wrote: > Bumping this for a last call RFC. > > It will be 2 weeks on Monday since the proposal, and since there's not > been a lot of traffic on the discussion, I'm planning on putting it up > to a vote at that time (unless there are any major

Re: [PHP-DEV] [RFC] Add hash_pbkdf2 function

2012-06-29 Thread Anthony Ferrara
Bumping this for a last call RFC. It will be 2 weeks on Monday since the proposal, and since there's not been a lot of traffic on the discussion, I'm planning on putting it up to a vote at that time (unless there are any major objections raised). So if anyone wants to comment prior to the vote, p

Re: [PHP-DEV] [RFC] Add hash_pbkdf2 function

2012-06-21 Thread Anthony Ferrara
Pierre, >>> I would update the RFC with the current available algorithms or >>> recommended to be used (depending on the usage or goal). >> >> When you say "currently available algorithms", are you talking about >> the hash library as a whole? Or recommended for use with PBKDF2? Or >> other iterat

Re: [PHP-DEV] [RFC] Add hash_pbkdf2 function

2012-06-21 Thread Anthony Ferrara
Jonathan, > I like this proposal, it could be useful to add a simpler api that has > defaults matching the NIST recommendation: > hash_password($password, $salt, $algo = 'sha1', $iterations = 1000); Checkout the other thread about adding a simple password API. As far as implementing that as well

RE: [PHP-DEV] [RFC] Add hash_pbkdf2 function

2012-06-20 Thread Jonathan Bond-Caron
On Mon Jun 18 07:14 PM, Anthony Ferrara wrote: > > https://wiki.php.net/rfc/hash_pbkdf2 > I like this proposal, it could be useful to add a simpler api that has defaults matching the NIST recommendation: hash_password($password, $salt, $algo = 'sha1', $iterations = 1000); if the salt doesn't h

Re: [PHP-DEV] [RFC] Add hash_pbkdf2 function

2012-06-20 Thread Anthony Ferrara
Pierre, On Jun 20, 2012 8:27 AM, "Pierre Joye" wrote: > > hi Anthony! > > On Wed, Jun 20, 2012 at 12:12 PM, Anthony Ferrara wrote: > > >> I would update the RFC with the current available algorithms or > >> recommended to be used (depending on the usage or goal). > > > > When you say "currently

Re: [PHP-DEV] [RFC] Add hash_pbkdf2 function

2012-06-20 Thread Pierre Joye
hi Anthony! On Wed, Jun 20, 2012 at 12:12 PM, Anthony Ferrara wrote: >> I would update the RFC with the current available algorithms or >> recommended to be used (depending on the usage or goal). > > When you say "currently available algorithms", are you talking about > the hash library as a who

Re: [PHP-DEV] [RFC] Add hash_pbkdf2 function

2012-06-20 Thread Anthony Ferrara
Pierre, > Very nice work! Thanks :) Thanks! > I would update the RFC with the current available algorithms or > recommended to be used (depending on the usage or goal). When you say "currently available algorithms", are you talking about the hash library as a whole? Or recommended for use with

Re: [PHP-DEV] [RFC] Add hash_pbkdf2 function

2012-06-20 Thread Enrico Zimuel
Hi Anthony, i think your RFC is very good! I like the idea to have PBKDF2 implementation that is able to act, at the same time, as secure hash value generator (without the length parameter) and as key derivation function (with the length parameter). I think we should be consistent with the API of

Re: [PHP-DEV] [RFC] Add hash_pbkdf2 function

2012-06-19 Thread Pierre Joye
hi Anthony! On Tue, Jun 19, 2012 at 1:14 AM, Anthony Ferrara wrote: > Hello all, > > Since there wasn't that much traffic on the draft version of the RFC, > I've moved it into Proposed. > >  https://wiki.php.net/rfc/hash_pbkdf2 > > What are your thoughts? Very nice work! Thanks :) I would updat

Re: [PHP-DEV] [RFC] Add hash_pbkdf2 function

2012-06-19 Thread Adam Jon Richardson
On Tue, Jun 19, 2012 at 6:23 AM, Tjerk Meesters wrote: > On 19 Jun, 2012, at 2:24 PM, Adam Jon Richardson wrote: >> >> One thing I'm wondering about is whether the last parameter could be >> changed from: >> raw_output = false >> >> To something like: >> output = "hex" (also allowing output = "ra

Re: [PHP-DEV] [RFC] Add hash_pbkdf2 function

2012-06-19 Thread Tjerk Meesters
On 19 Jun, 2012, at 2:24 PM, Adam Jon Richardson wrote: > On Mon, Jun 18, 2012 at 7:14 PM, Anthony Ferrara wrote: >> https://wiki.php.net/rfc/hash_pbkdf2 >> >> What are your thoughts? > > That's very nice, indeed. > > One thing I'm wondering about is whether the last parameter could be > cha

Re: [PHP-DEV] [RFC] Add hash_pbkdf2 function

2012-06-18 Thread Adam Jon Richardson
On Mon, Jun 18, 2012 at 7:14 PM, Anthony Ferrara wrote: >  https://wiki.php.net/rfc/hash_pbkdf2 > > What are your thoughts? That's very nice, indeed. One thing I'm wondering about is whether the last parameter could be changed from: raw_output = false To something like: output = "hex" (also all

[PHP-DEV] [RFC] Add hash_pbkdf2 function

2012-06-18 Thread Anthony Ferrara
Hello all, Since there wasn't that much traffic on the draft version of the RFC, I've moved it into Proposed. https://wiki.php.net/rfc/hash_pbkdf2 What are your thoughts? Thanks, Anthony -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.