Re: [PHP-DEV] [RFC] Add IntlDateTimePatternGenerator

2021-05-13 Thread Mel Dafert
I am planning to open the vote on this tomorrow, if there aren't any objections. -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: https://www.php.net/unsub.php

Re: [PHP-DEV] [RFC] Add IntlDateTimePatternGenerator

2021-04-30 Thread Mel Dafert
>For both points, I'd say "consistency wins by default." So if the other >classes in that package already skip "Time" and use ::create() instead of a >constructor, you should do the same as well unless there's a very good reason >not to. I have updated the RFC to use switch to the naming witho

Re: [PHP-DEV] [RFC] Add IntlDateTimePatternGenerator

2021-04-24 Thread Mel Dafert
> For both points, I'd say "consistency wins by default." So if the other > classes in that package already skip "Time" and > use ::create() instead of a constructor, you should do the same as well > unless there's a very good reason not to. The problem with ::create is that in the intl extensio

Re: [PHP-DEV] [RFC] Add IntlDateTimePatternGenerator

2021-04-24 Thread Larry Garfield
On Sat, Apr 24, 2021, at 10:12 AM, Mel Dafert wrote: > Hi Internals, > > I would like to propose an RFC > https://wiki.php.net/rfc/intldatetimepatterngenerator to add > IntlDateTimePatternGenerator > which exposes ICU's ability to flexibly create localized date/time > formatting patterns from a

[PHP-DEV] [RFC] Add IntlDateTimePatternGenerator

2021-04-24 Thread Mel Dafert
Hi Internals, I would like to propose an RFC https://wiki.php.net/rfc/intldatetimepatterngenerator to add IntlDateTimePatternGenerator which exposes ICU's ability to flexibly create localized date/time formatting patterns from a skeleton. Previous discussion: https://externals.io/message/11383