Hi
On 5/31/24 16:49, Saki Takamachi wrote:
I would like to start an RFC discussion regarding rounding modes.
https://wiki.php.net/rfc/correctly_name_the_rounding_mode_and_make_it_an_enum
We already wanted to announce the RFC vote, but then I forgot to do so
and then Claude's email came in. Oh
Hi
please apologize the delay in getting back to you. I was absolutely
swamped with mailing list mails, other work and I didn't want to give a
reply that I did not give any thought.
On 6/19/24 21:14, Claude Pache wrote:
Second, “TowardsPositiveInfinity” is just a mouthful synonym for “Up”. Y
Hi
On 6/24/24 22:11, Jordan LeDoux wrote:
If there is ONE improvement to be made with this RFC, it is to completely
remove "up" and "down" from the rounding terminology.
Please note that the RFC does not include the “Up” and “Down”
terminology in its proposal. It only uses it to describe whic
On Wed, Jun 19, 2024 at 12:16 PM Claude Pache
wrote:
>
> Second, “TowardsPositiveInfinity” is just a mouthful synonym for “Up”. You
> could just name it:
>
> Round::Up
>
> At this point, you may invoke either Hamming or Levenshtein and compare it
> negatively with `Round::HalfUp`. Yes there is a
On Wednesday, 19 June 2024 at 20:14, Claude Pache
wrote:
> Hi,
>
> Naming is hard, for sure. Here is my review. I find the names mostly
> reasonable, except Round::PositiveInfinity and Round::NegativeInfinity. I
> will discuss Round::PositiveInfinity.
>
> First:
>
> > I've discussed this wi
Hi,
Naming is hard, for sure. Here is my review. I find the names mostly
reasonable, except Round::PositiveInfinity and Round::NegativeInfinity. I will
discuss Round::PositiveInfinity.
First:
> I've discussed this with Saki. In that case the `HalfEven` and `HalfOdd`
> modes would also need t
Hi
On 6/13/24 03:28, Gina P. Banyard wrote:
Thank you, I think other than possibly prefixing the NegativeInfinity
and PositiveInfinity cases with "Towards" I am happy with the content
of the RFC.
I've discussed this with Saki. In that case the `HalfEven` and `HalfOdd`
modes would also need to
On Tuesday, 11 June 2024 at 20:47, Tim Düsterhus wrote:
> Hi
>
> Am 2024-06-08 02:29, schrieb Saki Takamachi:
>
> > Regarding 1, personally, I support Gina's opinion of only providing
> > the new rounding modes as an Enum.
> > This can be interpreted as changing the rounding mode to Enum, with
Hi
Am 2024-06-08 02:29, schrieb Saki Takamachi:
Regarding 1, personally, I support Gina's opinion of only providing
the new rounding modes as an Enum.
This can be interpreted as changing the rounding mode to Enum, with
the existing constants being kept simply for backward compatibility.
I've t
Hi,
> On Sunday, 2 June 2024 at 22:26, Jorg Sowa wrote:
>> > by *removing* the newly introduced constant and instead exposing the
>> > functionality *only* via the new Enum.
>>
>> It brings inconsistency that some modes are accessible by ints and enums and
>> others only by enums. If there is
Hi
On 6/3/24 18:23, Derick Rethans wrote:
I would like to start an RFC discussion regarding rounding modes.
https://wiki.php.net/rfc/correctly_name_the_rounding_mode_and_make_it_an_enum
I think it would be really helpful to have a description (and examples)
for each of the rounding modes in th
On Sunday, 2 June 2024 at 22:26, Jorg Sowa wrote:
>> by *removing* the newly introduced constant and instead exposing the
>> functionality *only* via the new Enum.
> It brings inconsistency that some modes are accessible by ints and enums and
> others only by enums. If there is no deprecation p
Hi
On 6/3/24 18:21, Derick Rethans wrote:
But they're well established in existing PHP features.
That does not mean that we shouldn't attempt to do better for newly
introduced APIs. Over time there will be more developers that will newly
learn PHP than there are developers that already know
Hi
On 6/2/24 23:26, Jorg Sowa wrote:
Far more people search for `ceiling` than `round toward positive infinity`
or `round positive infinity`. Of course, I may be wrong by choosing
Could it be the case that folks do not need to search as much for
“towards positive infinity”, because in contras
Hi
On 6/3/24 19:02, Jordan LeDoux wrote:
If the behavior of that mode is to ALWAYS round regardless of the value of
the remainder, then it should remain ceil IMO. It's a pretty well
understood behavior in many programming languages. However,
"HALF_TOWARDS_POSITIVE_INFINITY" is a different behavi
On Sun, Jun 2, 2024 at 2:27 PM Jorg Sowa wrote:
> > It should also be noted that ceil/floor is very English specific
> terminology that may not be immediately obvious to non-English speakers,
> thus my preference for using some variation of towards positive/negative
> infinity.
>
> This statement
On Fri, 31 May 2024, Saki Takamachi wrote:
> I would like to start an RFC discussion regarding rounding modes.
> https://wiki.php.net/rfc/correctly_name_the_rounding_mode_and_make_it_an_enum
I think it would be really helpful to have a description (and examples)
for each of the rounding modes i
On Sat, 1 Jun 2024, Gina P. Banyard wrote:
> On Friday, 31 May 2024 at 18:15, Larry Garfield
> wrote:
>
> > On Fri, May 31, 2024, at 4:41 PM, Jorg Sowa wrote:
> >
> > > Hey Saki, I like this change. When I was implementing additional
> > > rounding modes for the next PHP version I was initial
> It should also be noted that ceil/floor is very English specific
terminology that may not be immediately obvious to non-English speakers,
thus my preference for using some variation of towards positive/negative
infinity.
This statement is subjective in my opinion. For me, it's the contrary,
that
On Friday, 31 May 2024 at 15:49, Saki Takamachi wrote:
> Hi, internals!
>
> I would like to start an RFC discussion regarding rounding modes.
> https://wiki.php.net/rfc/correctly_name_the_rounding_mode_and_make_it_an_enum
>
> As mentioned previously by Gina on the mailing list [1], there ar
On Friday, 31 May 2024 at 18:15, Larry Garfield wrote:
> On Fri, May 31, 2024, at 4:41 PM, Jorg Sowa wrote:
>
> > Hey Saki,
> > I like this change. When I was implementing additional rounding modes
> > for the next PHP version I was initially struggling with the naming and
> > this change will b
On Fri, May 31, 2024, at 4:41 PM, Jorg Sowa wrote:
> Hey Saki,
> I like this change. When I was implementing additional rounding modes
> for the next PHP version I was initially struggling with the naming and
> this change will be helpful.
>
> I have only one concern about the names `NegativeInfi
Thank you for the clarification Erick
Sent from IPhone
On Fri, May 31, 2024 at 12:59 PM Erick de Azevedo Lima <
ericklima.c...@gmail.com> wrote:
> Hi.
>
> > I like the idea. But I don't know
> Please ignore this.
> Some copy-past leftovers.
>
> Sorry!
>
>
Hey Saki,
I like this change. When I was implementing additional rounding modes for
the next PHP version I was initially struggling with the naming and this
change will be helpful.
I have only one concern about the names `NegativeInfinity` and
`PositiveInfinity`. They may be too formal from the us
Hi.
> I like the idea. But I don't know
Please ignore this.
Some copy-past leftovers.
Sorry!
> To resolve these issues, change the naming to something appropriate and
use Enums instead of int constants.
Hi!
I like the idea. But I don't know
>From the RFC text:
> To summarize, existing features will be changed to a union type of int|
\RoundingMode, and unreleased features will only accept
Hi, internals!
I would like to start an RFC discussion regarding rounding modes.
https://wiki.php.net/rfc/correctly_name_the_rounding_mode_and_make_it_an_enum
As mentioned previously by Gina on the mailing list [1], there are some issues
with PHP's current rounding mode.
[1] - https://externals.
27 matches
Mail list logo
