Re: [PHP-DEV] [RFC] [Vote] var_info

2016-08-15 Thread Nikita Popov
On Fri, Jul 22, 2016 at 10:21 PM, Nikita Popov wrote: > On Sat, Jul 9, 2016 at 12:19 AM, Stanislav Malyshev > wrote: > >> Hi! >> >> > Lastly, I'll just leave this list of type-related improvements I'd >> actually >> > like to see: >> > * Make is_object() return true for IncompleteClass. This is

Re: [PHP-DEV] [RFC] [Vote] var_info

2016-07-22 Thread Nikita Popov
On Sat, Jul 9, 2016 at 12:19 AM, Stanislav Malyshev wrote: > Hi! > > > Lastly, I'll just leave this list of type-related improvements I'd > actually > > like to see: > > * Make is_object() return true for IncompleteClass. This is just > > ridiculous. I care zero about the theoretical BC impact.

Re: [PHP-DEV] [RFC] [Vote] var_info

2016-07-21 Thread Fleshgrinder
Many thanks for the feedback to both of you. :) On 7/8/2016 11:54 PM, Nikita Popov wrote: > You are doing a callability check for all arrays and strings. I wouldn't be > comfortable passing any data that potentially derives from external sources > (aka all data) to that function. E.g. this could t

Re: [PHP-DEV] [RFC] [Vote] var_info

2016-07-10 Thread Stanislav Malyshev
Hi! >> * Make is_object() return true for IncompleteClass. This is just >> ridiculous. I care zero about the theoretical BC impact. > > I have no idea why it doesn't do so. I'll try to dig up when it was made > so and see if there's some explanation. This is the change that caused it: commit 7

Re: [PHP-DEV] [RFC] [Vote] var_info

2016-07-08 Thread Stanislav Malyshev
Hi! > Lastly, I'll just leave this list of type-related improvements I'd actually > like to see: > * Make is_object() return true for IncompleteClass. This is just > ridiculous. I care zero about the theoretical BC impact. I have no idea why it doesn't do so. I'll try to dig up when it was made

Re: [PHP-DEV] [RFC] [Vote] var_info

2016-07-08 Thread Nikita Popov
On Fri, Jul 8, 2016 at 9:49 PM, Fleshgrinder wrote: > Hi! > > Voting on var_info has opened and will stay open until 2016-07-22: > > https://wiki.php.net/rfc/var_info > Not a big fan of this in general (imho belongs in userland), but I'd like to comment on one specific issue: You are doing a ca

[PHP-DEV] [RFC] [Vote] var_info

2016-07-08 Thread Fleshgrinder
Hi! Voting on var_info has opened and will stay open until 2016-07-22: https://wiki.php.net/rfc/var_info -- Richard "Fleshgrinder" Fussenegger signature.asc Description: OpenPGP digital signature