Re: [PHP-DEV] [RFC] [Vote] Deprecate functions with overloaded signatures

2023-07-03 Thread Theodore Brown
On Thu June 29, 2023 at 11:51 AM Theodore Brown wrote: > On Tue, June 27, 2023, 6:33 Rowan Tommins wrote: > > On 27/06/2023 02:25, Theodore Brown wrote: > > > Currently the following code returns only the array keys that loosely > > > equal null: > > > > > > array_keys($array, null) > > > > >

Re: [PHP-DEV] [RFC] [Vote] Deprecate functions with overloaded signatures

2023-06-29 Thread Theodore Brown
On Tue, June 27, 2023, 6:33 Rowan Tommins wrote: > On 27/06/2023 02:25, Theodore Brown wrote: > > Currently the following code returns only the array keys that loosely equal > > null: > > > > array_keys($array, null) > > > > If the function is changed to a single signature with $filter_value

Re: [PHP-DEV] [RFC] [Vote] Deprecate functions with overloaded signatures

2023-06-27 Thread Rowan Tommins
On 27/06/2023 02:25, Theodore Brown wrote: Currently the following code returns only the array keys that loosely equal null [1]: array_keys($array, null) If the function is changed to a single signature with $filter_value defaulting to null (with an argument count check to preserve the a

Re: [PHP-DEV] [RFC] [Vote] Deprecate functions with overloaded signatures

2023-06-26 Thread Aleksander Machniak
On 26.06.2023 20:22, Ben Ramsey wrote: I voted “no” on `IntlCalendar::set()` because it seems to me that `setDate()` and `setDateTime()` could share the same signature if `$hour`, `$minute`, and `$second` all default to zero, like this: public function setDate(int $year, int $month, int

Re: [PHP-DEV] [RFC] [Vote] Deprecate functions with overloaded signatures

2023-06-26 Thread Theodore Brown
On Mon, June 26, 2023, at 14:43 Nikita Popov wrote: > On Mon, Jun 26, 2023, at 20:22, Ben Ramsey wrote: > > > > I voted “no” on `array_keys()` because I do not see these as two different > > function signatures. To me, the single signature should look like this: > > > > function array_keys(arr

Re: [PHP-DEV] [RFC] [Vote] Deprecate functions with overloaded signatures

2023-06-26 Thread Nikita Popov
On Mon, Jun 26, 2023, at 20:22, Ben Ramsey wrote: > > On Jun 26, 2023, at 08:36, Máté Kocsis wrote: > > > > Hi Everyone, > > > > As previously announced on the list, I have just started the vote about the > > "Deprecate functions with overloaded signatures". > > > > Link to the RFC: > > https:/

Re: [PHP-DEV] [RFC] [Vote] Deprecate functions with overloaded signatures

2023-06-26 Thread Ben Ramsey
> On Jun 26, 2023, at 08:36, Máté Kocsis wrote: > > Hi Everyone, > > As previously announced on the list, I have just started the vote about the > "Deprecate functions with overloaded signatures". > > Link to the RFC: > https://wiki.php.net/rfc/deprecate_functions_with_overloaded_signatures > L

Re: [PHP-DEV] [RFC] [Vote] Deprecate functions with overloaded signatures

2023-06-26 Thread Marco Pivetta
Hey Máté, Only voted "NO" for `ReflectionProperty#setValue()`, mostly because any kind of pre-existing subtype will be kinda broken, but it isn't a major issue. It's fine if libraries drop support for PHP 8.2 before PHP 9.0 is out. Marco Pivetta https://mastodon.social/@ocramius https://ocrami

[PHP-DEV] [RFC] [Vote] Deprecate functions with overloaded signatures

2023-06-26 Thread Máté Kocsis
Hi Everyone, As previously announced on the list, I have just started the vote about the "Deprecate functions with overloaded signatures". Link to the RFC: https://wiki.php.net/rfc/deprecate_functions_with_overloaded_signatures Link to the discussion thread: https://externals.io/message/120146 T