Re: [PHP-DEV] [RFC] [VOTE] Preserve Fractional Part in JSON encode

2015-01-19 Thread Ferenc Kovacs
On Sun, Jan 18, 2015 at 6:37 AM, Pierre Joye wrote: > On Jan 18, 2015 11:24 AM, "Juan Basso" wrote: > > > > The vote is now closed. By 14x0 the RFC was accepted. > > > > Since I am not part of the core team, who can merge the PR ( > > https://github.com/php/php-src/pull/642)? By the way, the RFC

Re: [PHP-DEV] [RFC] [VOTE] Preserve Fractional Part in JSON encode

2015-01-19 Thread Juan Basso
Can you also resolve https://bugs.php.net/bug.php?id=50224 ? Thanks. On Jan 19, 2015 3:48 AM, "Stanislav Malyshev" wrote: > Hi! > > > Since I am not part of the core team, who can merge the PR ( > > https://github.com/php/php-src/pull/642)? By the way, the RFC was > target to > > the next PHP 5.

Re: [PHP-DEV] [RFC] [VOTE] Preserve Fractional Part in JSON encode

2015-01-19 Thread Stanislav Malyshev
Hi! > Since I am not part of the core team, who can merge the PR ( > https://github.com/php/php-src/pull/642)? By the way, the RFC was target to > the next PHP 5.6 patch version, but the PR was target to master. Should I > reopen the PR to PHP-5.6 branch? No, I think we can do with the existing o

Re: [PHP-DEV] [RFC] [VOTE] Preserve Fractional Part in JSON encode

2015-01-18 Thread Stanislav Malyshev
Hi! > I do not know who are the "people" but the release process is pretty > clear on that. We decided not to allow features additions to ease > developers life, like not having to do dozen of tests to know which > minor versions added what. It is also why we have yearly releases, We have always

Re: [PHP-DEV] [RFC] [VOTE] Preserve Fractional Part in JSON encode

2015-01-18 Thread Andrea Faulds
Hey Pierre, > On 18 Jan 2015, at 17:17, Pierre Joye wrote: > > Except that this one is not self contained and the rfc says in rare cases > (or say, for good reason). Does it? With the flag turned off (default), behaviour is exactly the same as before. With the flag on, behaviour is changed.

Re: [PHP-DEV] [RFC] [VOTE] Preserve Fractional Part in JSON encode

2015-01-18 Thread Pierre Joye
On Jan 19, 2015 12:13 AM, "Nikita Popov" wrote: > > On Sun, Jan 18, 2015 at 6:02 PM, Pierre Joye wrote: >> >> On Sun, Jan 18, 2015 at 11:27 PM, Juan Basso wrote: >> > During the discussion process it was discussed and people were ok with it >> > since it doesn't break any existing code. Also, JS

Re: [PHP-DEV] [RFC] [VOTE] Preserve Fractional Part in JSON encode

2015-01-18 Thread Nikita Popov
On Sun, Jan 18, 2015 at 6:02 PM, Pierre Joye wrote: > On Sun, Jan 18, 2015 at 11:27 PM, Juan Basso wrote: > > During the discussion process it was discussed and people were ok with it > > since it doesn't break any existing code. Also, JSON_NUMERIC_CHECK option > > was added on json_encode in pa

Re: [PHP-DEV] [RFC] [VOTE] Preserve Fractional Part in JSON encode

2015-01-18 Thread Pierre Joye
On Sun, Jan 18, 2015 at 11:27 PM, Juan Basso wrote: > During the discussion process it was discussed and people were ok with it > since it doesn't break any existing code. Also, JSON_NUMERIC_CHECK option > was added on json_encode in patch version (added on 5.3.3). I do not know who are the "peo

Re: [PHP-DEV] [RFC] [VOTE] Preserve Fractional Part in JSON encode

2015-01-18 Thread Juan Basso
During the discussion process it was discussed and people were ok with it since it doesn't break any existing code. Also, JSON_NUMERIC_CHECK option was added on json_encode in patch version (added on 5.3.3). On Sun, Jan 18, 2015 at 12:37 AM, Pierre Joye wrote: > > On Jan 18, 2015 11:24 AM, "Juan

Re: [PHP-DEV] [RFC] [VOTE] Preserve Fractional Part in JSON encode

2015-01-17 Thread Pierre Joye
On Jan 18, 2015 11:24 AM, "Juan Basso" wrote: > > The vote is now closed. By 14x0 the RFC was accepted. > > Since I am not part of the core team, who can merge the PR ( > https://github.com/php/php-src/pull/642)? By the way, the RFC was target to > the next PHP 5.6 patch version, but the PR was ta

Re: [PHP-DEV] [RFC] [VOTE] Preserve Fractional Part in JSON encode

2015-01-17 Thread Juan Basso
The vote is now closed. By 14x0 the RFC was accepted. Since I am not part of the core team, who can merge the PR ( https://github.com/php/php-src/pull/642)? By the way, the RFC was target to the next PHP 5.6 patch version, but the PR was target to master. Should I reopen the PR to PHP-5.6 branch?

Re: [PHP-DEV] [RFC] [VOTE] Preserve Fractional Part in JSON encode

2015-01-17 Thread Pascal MARTIN, AFUP
On 11/01/2015 04:02, Juan Basso wrote: I'd like to initiate a vote on this RFC: https://wiki.php.net/rfc/json_preserve_fractional_part Hi, After discussing this RFC with other people of AFUP, we are +1 on this. Being able to get back the same PHP type after encoding data to JSON and re-deco

[PHP-DEV] [RFC] [VOTE] Preserve Fractional Part in JSON encode

2015-01-10 Thread Juan Basso
I'd like to initiate a vote on this RFC: https://wiki.php.net/rfc/json_preserve_fractional_part TLDR: this RFC would add a new json_encode option to preserve fractional part of float numbers when they are 0. Ie, encoding (float)10 to json will be 10.0. PS: This is not enabled by default. The code