Re: [PHP-DEV] [RFC] [VOTE] FFI - Foreign Function Interface

2018-12-30 Thread Jan Ehrhardt
"Christoph M. Becker" in php.internals (Sat, 29 Dec 2018 12:27:58 +0100): >As I understand it, the extension would not be compiled by default, but >rather has to be enabled using an explicit --with-ffi configure >option[1] (or --enable-ffi on Windows[2]). A strange difference. Is not the conventio

Re: [PHP-DEV] [RFC] [VOTE] FFI - Foreign Function Interface

2018-12-29 Thread Christoph M. Becker
On 29.12.2018 at 00:59, Stanislav Malyshev wrote: > If this extension were not enabled by default and required explicit > enabling action to build - that's fine, if you did it, we assume you > know what you're doing enough to assume the risk. But if it's present > and enabled by default in a commo

Re: [PHP-DEV] [RFC] [VOTE] FFI - Foreign Function Interface

2018-12-28 Thread Stanislav Malyshev
Hi! I like the idea of having such an agile API in the language. But I am, like many others, somewhat worried about security implication of this extension. In theory, it does not give the attacker anything they don't already have - if you have PHP code access, you can probably execute anything on

Re: [PHP-DEV] [RFC] [VOTE] FFI - Foreign Function Interface

2018-12-25 Thread Jefferson Gonzalez
On 12/25/18 12:20 PM, Derick Rethans wrote: There is no need to go from new extension with a new unproven API to directly into core as first try. It's much better to try things out in for example PECL and then to promote it to a core extension when all the kinks are worked out. True, but in

Re: [PHP-DEV] [RFC] [VOTE] FFI - Foreign Function Interface

2018-12-25 Thread Derick Rethans
On 24 December 2018 16:37:27 GMT, Jefferson Gonzalez wrote: > Can people explain why they are voting no to a feature that seems > really well put and thought? There is no need to go from new extension with a new unproven API to directly into core as first try. It's much better to try things ou

Re: [PHP-DEV] [RFC] [VOTE] FFI - Foreign Function Interface

2018-12-24 Thread Pierre Joye
Hi, I agree with the comments about safety here however I still vote yes. FFI and Jit integration will be a critical part of php in a near future. As I have seen in the past, it is extremely time consuming to maintain such implementation outside the core, especially if performance and tight integr

Re: [PHP-DEV] [RFC] [VOTE] FFI - Foreign Function Interface

2018-12-24 Thread Jefferson Gonzalez
Is sad to see people voting against this feature, which would help move PHP into territories outside of the web development landscape. For those developers not interested in learning the zend engine (lack of time) but with enough knowledge about C, this extension would surely help a lot when in

Re: [PHP-DEV] [RFC] [VOTE] FFI - Foreign Function Interface

2018-12-24 Thread Dmitry Stogov
On 12/24/18 4:50 PM, Christoph M. Becker wrote: > On 24.12.2018 at 08:38, Dmitry Stogov wrote: > >> On 12/22/18 1:32 PM, Nikita Popov wrote: >> >>> My main concern here is that this is a very new extension and I think >>> that apart from you barely anyone had a chance to actually implement >>> s

Re: [PHP-DEV] [RFC] [VOTE] FFI - Foreign Function Interface

2018-12-24 Thread Christoph M. Becker
On 24.12.2018 at 08:38, Dmitry Stogov wrote: > On 12/22/18 1:32 PM, Nikita Popov wrote: > >> My main concern here is that this is a very new extension and I think >> that apart from you barely anyone had a chance to actually implement >> something based on it and gain experience using the propos

Re: [PHP-DEV] [RFC] [VOTE] FFI - Foreign Function Interface

2018-12-23 Thread Dmitry Stogov
On 12/22/18 1:32 PM, Nikita Popov wrote: > On Thu, Dec 20, 2018 at 4:13 PM Dmitry Stogov > wrote: > > Hi internals, > > > The FFI RFC is turned into voting state. > > > https://wiki.php.net/rfc/ffi > > > There were very few minor changes since the i

Re: [PHP-DEV] [RFC] [VOTE] FFI - Foreign Function Interface

2018-12-23 Thread Levi Morrison
Dmitry, I am very interested in FFI behavior. I voted no only because I do not believe this extension is mature enough for inclusion in core. Getting TensorFlow to work in PHP-land using the FFI is definitely an interesting and noteworthy achievement, but I think it is insufficient for inclusion i

Re: [PHP-DEV] [RFC] [VOTE] FFI - Foreign Function Interface

2018-12-23 Thread Niklas Keller
Am Sa., 22. Dez. 2018 um 11:32 Uhr schrieb Nikita Popov : > > On Thu, Dec 20, 2018 at 4:13 PM Dmitry Stogov wrote: > > > Hi internals, > > > > > > The FFI RFC is turned into voting state. > > > > > > https://wiki.php.net/rfc/ffi > > > > > > There were very few minor changes since the initial propo

Re: [PHP-DEV] [RFC] [VOTE] FFI - Foreign Function Interface

2018-12-22 Thread Andrea Faulds
Dmitry Stogov wrote: Hi internals, The FFI RFC is turned into voting state. https://wiki.php.net/rfc/ffi There were very few minor changes since the initial proposal, e.g. renaming FFI:array_type() into FFI::arrayType() Thanks. Dmitry. Hi Dmitry, Reading Sara's concern about it bein

Re: [PHP-DEV] [RFC] [VOTE] FFI - Foreign Function Interface

2018-12-22 Thread Nikita Popov
On Thu, Dec 20, 2018 at 4:13 PM Dmitry Stogov wrote: > Hi internals, > > > The FFI RFC is turned into voting state. > > > https://wiki.php.net/rfc/ffi > > > There were very few minor changes since the initial proposal, e.g. > renaming FFI:array_type() into FFI::arrayType() > > > Thanks. Dmitry. >

Re: [PHP-DEV] [RFC] [VOTE] FFI - Foreign Function Interface

2018-12-22 Thread Michael Wallner
Am Do., 20. Dez. 2018, 16:13 hat Dmitry Stogov geschrieben: > Hi internals, > > > The FFI RFC is turned into voting state. > > > https://wiki.php.net/rfc/ffi > ... As the other one, lagging hugely behind, I'll refrain my vote. Regards, Mike

[PHP-DEV] [RFC] [VOTE] FFI - Foreign Function Interface

2018-12-20 Thread Dmitry Stogov
Hi internals, The FFI RFC is turned into voting state. https://wiki.php.net/rfc/ffi There were very few minor changes since the initial proposal, e.g. renaming FFI:array_type() into FFI::arrayType() Thanks. Dmitry.