Re: [PHP-DEV] [RFC] [VOTE] Class Friendship

2018-07-09 Thread Dustin Wheeler
On Sat, Jul 7, 2018 at 6:46 PM Yasuo Ohgaki wrote: > > I would like to vote to "yes". > However, RFC does not have benchmark result. Do you have some results? > > Regards, > > -- > Yasuo Ohgaki > yohg...@ohgaki.net > Yasuo, I have documented a benchmark based on my last comment. This benchmark

Re: [PHP-DEV] [RFC] [VOTE] Class Friendship

2018-07-07 Thread Dustin Wheeler
On Sat, Jul 7, 2018 at 6:46 PM Yasuo Ohgaki wrote: > > I would like to vote to "yes". > However, RFC does not have benchmark result. Do you have some results? > > Regards, > > -- > Yasuo Ohgaki > yohg...@ohgaki.net > > I have not run a benchmark on the current implementation but would be happy t

Re: [PHP-DEV] [RFC] [VOTE] Class Friendship

2018-07-07 Thread Yasuo Ohgaki
On Sat, Jul 7, 2018 at 5:26 AM Dustin Wheeler wrote: > Hello, > > I've let this RFC linger for a long time and finally wrapped up the > remaining administrative items to put it to vote. This has been > discussed a few times in the past: > > https://externals.io/message/89732 > https://externals.i

Re: [PHP-DEV] [RFC] [VOTE] Class Friendship

2018-07-07 Thread Dustin Wheeler
On Sat, Jul 7, 2018 at 12:09 PM Niklas Keller wrote: > > Hey, > > could you please fix the creation date in the RFC? It lists > 2018-06-27, which would mean that the minimum discussion period > wouldn't be over, yet, but it's actually been created somewhen last > year. > Ugh, sorry about that! In

Re: [PHP-DEV] [RFC] [VOTE] Class Friendship

2018-07-07 Thread Niklas Keller
Hey, could you please fix the creation date in the RFC? It lists 2018-06-27, which would mean that the minimum discussion period wouldn't be over, yet, but it's actually been created somewhen last year. Regards, Niklas -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visi

Re: [PHP-DEV] [RFC] [VOTE] Class Friendship

2018-07-07 Thread Dan Ackroyd
Hi Internals. To explain my vote, I'm voting no for pretty much the same reasons I listed before, http://news.php.net/php.internals/90352 The short version of which is: * 'friendship' is not a good solution for allowing restricted access to some methods. * Restricting access to some methods doe

Re: [PHP-DEV] [RFC] [VOTE] Class Friendship

2018-07-06 Thread David Rodrigues
I really like this. But the name "friend" sounds strange. Is not possible think about alternative names? Maybe "accessible from X" or "allow X". Em sex, 6 de jul de 2018 17:25, Dustin Wheeler escreveu: > Hello, > > I've let this RFC linger for a long time and finally wrapped up the > remaining a

[PHP-DEV] [RFC] [VOTE] Class Friendship

2018-07-06 Thread Dustin Wheeler
Hello, I've let this RFC linger for a long time and finally wrapped up the remaining administrative items to put it to vote. This has been discussed a few times in the past: https://externals.io/message/89732 https://externals.io/message/90311 I would like to open the vote for an RFC to support